Re: dBm cutoff at -1dBm is too low

2006-05-09 Thread Jean Tourrilhes
On Tue, May 09, 2006 at 12:54:55AM -0400, Pavel Roskin wrote: > On Mon, 2006-05-08 at 10:17 -0700, Jean Tourrilhes wrote: > > > But shouldn't you trust the drivers using IW_QUAL_DBM, whether the value > > > is positive or negative? > > > > You can't remove the test, making the rest pointeless.

Re: dBm cutoff at -1dBm is too low

2006-05-08 Thread Pavel Roskin
On Mon, 2006-05-08 at 10:17 -0700, Jean Tourrilhes wrote: > > But shouldn't you trust the drivers using IW_QUAL_DBM, whether the value > > is positive or negative? > > You can't remove the test, making the rest pointeless. Old > style driver never used the flags, new style driver that don't

Re: dBm cutoff at -1dBm is too low

2006-05-08 Thread Jean Tourrilhes
On Sat, May 06, 2006 at 11:32:12PM -0400, Pavel Roskin wrote: > On Fri, 2006-05-05 at 10:28 -0700, Jean Tourrilhes wrote: > > > > There are still quite a few drivers which have not been > > converted to use IW_QUAL_DBM, so I don't want to drop the backward > > compatibility yet. > > But shoul

Re: dBm cutoff at -1dBm is too low

2006-05-07 Thread Pavel Roskin
On Fri, 2006-05-05 at 10:28 -0700, Jean Tourrilhes wrote: > I tried to use 'signed' in the struct a long while ago, and > for some reason it broke left and right, I don't remember the > details. So, whatever we do, it would not be straightforward. Then let's keep the structure as is and chan

Re: dBm cutoff at -1dBm is too low

2006-05-06 Thread Pavel Roskin
On Fri, 2006-05-05 at 10:28 -0700, Jean Tourrilhes wrote: > Note that the main limitation is that before I introduced the > explicit IW_QUAL_DBM in WE-19, the way to know if the value was > relative or dBm was to use the 'sign' of it, i.e. value above 0 were > non-dBm. The test is a few line

Re: dBm cutoff at -1dBm is too low

2006-05-05 Thread Jean Tourrilhes
On Thu, May 04, 2006 at 12:37:45PM -0400, Pavel Roskin wrote: > Hello, Jean! > > I'm converting Orinoco to the dBm reporting, and it turns out that the > best signal iwconfig will report is -1dBm (0.8mW). This would happen if > qual->level has its highest value of 255. Please see this code from

dBm cutoff at -1dBm is too low

2006-05-04 Thread Pavel Roskin
Hello, Jean! I'm converting Orinoco to the dBm reporting, and it turns out that the best signal iwconfig will report is -1dBm (0.8mW). This would happen if qual->level has its highest value of 255. Please see this code from wireless_tools.29.pre10: len = snprintf(buffer, buflen, "Signal level%c