Re: circular locking dependency splat

2017-11-06 Thread Eric Dumazet
On Tue, 2017-11-07 at 09:35 +0900, David Ahern wrote: > Saw this trying to reproduce the RA splat. This is from top of tree > net-next: > commit 2798b80b385384d51a81832556ee9ad25d175f9b > > [ 99.988789] == > [ 99.990494] WARNING: possible cir

circular locking dependency splat

2017-11-06 Thread David Ahern
Saw this trying to reproduce the RA splat. This is from top of tree net-next: commit 2798b80b385384d51a81832556ee9ad25d175f9b [ 99.988789] == [ 99.990494] WARNING: possible circular locking dependency detected [ 99.992187] 4.14.0-rc7+ #23 N

Re: circular locking dependency splat due to f9eb8aea2a1e

2016-06-08 Thread Eric Dumazet
All devices that are missing busylock were already buggy ;) On Wed, Jun 8, 2016 at 1:59 PM, David Ahern wrote: > On 6/8/16 2:32 PM, Eric Dumazet wrote: >> >> On Wed, Jun 8, 2016 at 1:31 PM, David Ahern >> wrote: >>> >>> On 6/8/16 2:30 PM, Eric Dumazet wrote: It looks VRF was

Re: circular locking dependency splat due to f9eb8aea2a1e

2016-06-08 Thread David Ahern
On 6/8/16 2:32 PM, Eric Dumazet wrote: On Wed, Jun 8, 2016 at 1:31 PM, David Ahern wrote: On 6/8/16 2:30 PM, Eric Dumazet wrote: It looks VRF was already lacking annotation for busylock then ? I sent a patch adding IFF_NO_QUEUE flag OK, but we still need the fix, in case a qdisc is ins

Re: circular locking dependency splat due to f9eb8aea2a1e

2016-06-08 Thread Eric Dumazet
On Wed, Jun 8, 2016 at 1:31 PM, David Ahern wrote: > On 6/8/16 2:30 PM, Eric Dumazet wrote: >> >> >> It looks VRF was already lacking annotation for busylock then ? > > > I sent a patch adding IFF_NO_QUEUE flag > OK, but we still need the fix, in case a qdisc is installed on vrf (who knows...) I

Re: circular locking dependency splat due to f9eb8aea2a1e

2016-06-08 Thread David Ahern
On 6/8/16 2:30 PM, Eric Dumazet wrote: It looks VRF was already lacking annotation for busylock then ? I sent a patch adding IFF_NO_QUEUE flag

Re: circular locking dependency splat due to f9eb8aea2a1e

2016-06-08 Thread Eric Dumazet
On Wed, Jun 8, 2016 at 11:17 AM, David Ahern wrote: > Getting the below splat with ping in a VRF. git bisect points to: > > dsa@kenny:~/kernel-2.git$ git bisect good > f9eb8aea2a1e12fc2f584d1627deeb957435a801 is the first bad commit > commit f9eb8aea2a1e12fc2f584d1627deeb957435a801 > Author: Eric

circular locking dependency splat due to f9eb8aea2a1e

2016-06-08 Thread David Ahern
Getting the below splat with ping in a VRF. git bisect points to: dsa@kenny:~/kernel-2.git$ git bisect good f9eb8aea2a1e12fc2f584d1627deeb957435a801 is the first bad commit commit f9eb8aea2a1e12fc2f584d1627deeb957435a801 Author: Eric Dumazet Date: Mon Jun 6 09:37:15 2016 -0700 net_sched: