Bill Nottingham wrote:
David Miller ([EMAIL PROTECTED]) said:
From: Xavier Bestel <[EMAIL PROTECTED]>
Date: Thu, 17 Aug 2006 09:29:43 +0200
Why not simply retricting chars to isalnum() ones ?
As Bill said that would block things like "-" and "_" which are fine.
Bill also menti
David Miller ([EMAIL PROTECTED]) said:
> From: Xavier Bestel <[EMAIL PROTECTED]>
> Date: Thu, 17 Aug 2006 09:29:43 +0200
>
> > Why not simply retricting chars to isalnum() ones ?
>
> As Bill said that would block things like "-" and "_" which are fine.
>
> Bill also mentioned something about "b
From: Alan Cox <[EMAIL PROTECTED]>
Date: Fri, 18 Aug 2006 01:34:43 +0100
> Ar Iau, 2006-08-17 am 16:23 -0700, ysgrifennodd David Miller:
> > All you "name purists", go rename the block device name that is used
> > for your root partition to something with a space in it
>
> Works fine. It doesn't
Ar Iau, 2006-08-17 am 16:23 -0700, ysgrifennodd David Miller:
> Nobody in their right mind puts a space in their network device name.
It works fine. Been there done that. I'm probably not in my right mind
but it causes no problems. Nor btw does UTF-8 naming which is handy if
you want to name your
From: Xavier Bestel <[EMAIL PROTECTED]>
Date: Thu, 17 Aug 2006 09:29:43 +0200
> Why not simply retricting chars to isalnum() ones ?
As Bill said that would block things like "-" and "_" which are fine.
Bill also mentioned something about "breaking configs going back to
2.4.x" which is bogus beca
Xavier Bestel ([EMAIL PROTECTED]) said:
> > I think it's sane to avoid control characters and unicode/iso*, since they
> > can interfere with log output or analysis. I only thought about the kernel
> > itself and the corresponding userspace tools, which should handle any
> > character sequence jus
On Wed, 2006-08-16 at 17:11, Bodo Eggert wrote:
> On Wed, 16 Aug 2006, Bill Nottingham wrote:
> > Giacomo A. Catenazzi ([EMAIL PROTECTED]) said:
>
> > > > Are you willing to work to add the special case code necessary to
> > > > handle whitespace characters in the device name over all of the kern
On Wed, 16 Aug 2006, Bill Nottingham wrote:
> Giacomo A. Catenazzi ([EMAIL PROTECTED]) said:
> > > Are you willing to work to add the special case code necessary to
> > > handle whitespace characters in the device name over all of the kernel
> > > code and also all of the userland tools too?
> >
Bill Nottingham wrote:
Giacomo A. Catenazzi ([EMAIL PROTECTED]) said:
Are you willing to work to add the special case code necessary to
handle whitespace characters in the device name over all of the kernel
code and also all of the userland tools too?
But if you don't handle spaces in userspace
Giacomo A. Catenazzi ([EMAIL PROTECTED]) said:
> > Are you willing to work to add the special case code necessary to
> > handle whitespace characters in the device name over all of the kernel
> > code and also all of the userland tools too?
>
> But if you don't handle spaces in userspace, you han
David Miller wrote:
> From: Bodo Eggert <[EMAIL PROTECTED]>
> Date: Wed, 16 Aug 2006 02:02:03 +0200
>
>> Stephen Hemminger <[EMAIL PROTECTED]> wrote:
>>
>>> IMHO idiots who put space's in filenames should be ignored. As long as the
>>> bonding code doesn't throw a fatal error, it has every right t
From: Bodo Eggert <[EMAIL PROTECTED]>
Date: Wed, 16 Aug 2006 02:02:03 +0200
> Stephen Hemminger <[EMAIL PROTECTED]> wrote:
>
> > IMHO idiots who put space's in filenames should be ignored. As long as the
> > bonding code doesn't throw a fatal error, it has every right to return
> > "No such devic
Stephen Hemminger <[EMAIL PROTECTED]> wrote:
> IMHO idiots who put space's in filenames should be ignored. As long as the
> bonding code doesn't throw a fatal error, it has every right to return
> "No such device" to the fool.
Maybe you should limit device names to eight uppercase characters and
On Tue, 15 Aug 2006 15:56:12 -0700 (PDT)
David Miller <[EMAIL PROTECTED]> wrote:
> From: Stephen Hemminger <[EMAIL PROTECTED]>
> Date: Tue, 15 Aug 2006 15:44:44 -0700
>
> > IMHO idiots who put space's in filenames should be ignored. As long
> > as the bonding code doesn't throw a fatal error, it
On Tue, 15 Aug 2006, David Miller wrote:
>
> I agree that whitespace in device names push the limits of sanity.
>
> But if we believe that, we should enforce it in dev_valid_name().
>
> Does anyone really mind if I add the whitespace check there?
>
I have no objections. It would certainly make
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Tue, 15 Aug 2006 15:44:44 -0700
> IMHO idiots who put space's in filenames should be ignored. As long
> as the bonding code doesn't throw a fatal error, it has every right
> to return "No such device" to the fool.
I agree that whitespace in device
On Tue, 15 Aug 2006 15:41:08 -0700
Mitch Williams <[EMAIL PROTECTED]> wrote:
> On Tue, 15 Aug 2006, Bill Nottingham wrote:
> >
> > Stephen Hemminger ([EMAIL PROTECTED]) said:
> > > > They're certainly allowed, and the sysfs directory structure, files,
> > > > etc. handle it ok. Userspace tends to
On Tue, 15 Aug 2006, Bill Nottingham wrote:
>
> Stephen Hemminger ([EMAIL PROTECTED]) said:
> > > They're certainly allowed, and the sysfs directory structure, files,
> > > etc. handle it ok. Userspace tends to break in a variety of ways.
> > >
> > > I believe the only invalid character in an inter
Stephen Hemminger ([EMAIL PROTECTED]) said:
> > They're certainly allowed, and the sysfs directory structure, files,
> > etc. handle it ok. Userspace tends to break in a variety of ways.
> >
> > I believe the only invalid character in an interface name is '/'.
> >
>
> The names "." and ".." are
On Tue, 15 Aug 2006 16:45:55 -0400
Bill Nottingham <[EMAIL PROTECTED]> wrote:
> Mitch Williams ([EMAIL PROTECTED]) said:
> > Are spaces allowed in interface names anyway? I can't believe that
> > bonding is the only area affected by this.
>
> They're certainly allowed, and the sysfs directory s
Mitch Williams ([EMAIL PROTECTED]) said:
> Are spaces allowed in interface names anyway? I can't believe that
> bonding is the only area affected by this.
They're certainly allowed, and the sysfs directory structure, files,
etc. handle it ok. Userspace tends to break in a variety of ways.
I bel
On Tue, 15 Aug 2006, Bill Nottingham wrote:
> 2.6.17-rc4+.
>
> Trivial example:
>
> # modprobe bonding (creates bond0)
> # ip link set bond0 name "a b"
> # echo "-a b" > /sys/class/net/bonding_masters
> bonding: unable to delete non-existent bond a
> bash: echo: write error: No such device
>
Yuc
2.6.17-rc4+.
Trivial example:
# modprobe bonding (creates bond0)
# ip link set bond0 name "a b"
# echo "-a b" > /sys/class/net/bonding_masters
bonding: unable to delete non-existent bond a
bash: echo: write error: No such device
Bill
-
To unsubscribe from this list: send the line "unsubscribe n
23 matches
Mail list logo
