Re: bond_compute_features() does not handle devices with different CSUM

2007-05-30 Thread Stephen Hemminger
On Wed, 30 May 2007 09:58:38 -0700 "Laurent Chavey" <[EMAIL PROTECTED]> wrote: > should we then move/integrate that code as part of the bonding driver ? > > > On 5/30/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > On Tue, 29 May 2007 17:41:45 -0700 > > "Laurent Chavey" <[EMAIL PROTECTED]>

Re: bond_compute_features() does not handle devices with different CSUM

2007-05-30 Thread Laurent Chavey
should we then move/integrate that code as part of the bonding driver ? On 5/30/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: On Tue, 29 May 2007 17:41:45 -0700 "Laurent Chavey" <[EMAIL PROTECTED]> wrote: > kernel version <= 2.6.20.1 > file drivers/net/bonding/bonding_main.c > function bond

Re: bond_compute_features() does not handle devices with different CSUM

2007-05-30 Thread Stephen Hemminger
On Tue, 29 May 2007 17:41:45 -0700 "Laurent Chavey" <[EMAIL PROTECTED]> wrote: > kernel version <= 2.6.20.1 > file drivers/net/bonding/bonding_main.c > function bond_compute_features() > > --- > Given a system with two different NIC. One driver sets > dev->features |= NETIF_F_H

Re: bond_compute_features() does not handle devices with different CSUM

2007-05-30 Thread Laurent Chavey
corrected diff. --- 2.6.20/drivers/net/bonding/bond_main.c 2007-05-29 19:43:39.010565000 -0700 +++ 2.6.20.fix/drivers/net/bonding/bond_main.c 2007-05-30 08:18:24.018322000 -0700 @@ -1227,7 +1227,14 @@ int i; bond_for_each_slave(bond, slave, i) { - features &= (s

Re: bond_compute_features() does not handle devices with different CSUM

2007-05-30 Thread Laurent Chavey
features = features & (dev_features & BOND_INTERSECT_FEATURES); On 5/30/07, Michael Buesch <[EMAIL PROTECTED]> wrote: On Wednesday 30 May 2007 04:47:09 Laurent Chavey wrote: > proposed change. > > --- 2.6.20/drivers/net/bonding/bond_main.c 2007-05-29 > 19:43:39.010565000 -0700 > +++ 2.6.20.

Re: bond_compute_features() does not handle devices with different CSUM

2007-05-30 Thread Michael Buesch
On Wednesday 30 May 2007 04:47:09 Laurent Chavey wrote: > proposed change. > > --- 2.6.20/drivers/net/bonding/bond_main.c 2007-05-29 > 19:43:39.010565000 -0700 > +++ 2.6.20.fix/drivers/net/bonding/bond_main.c 2007-05-29 > 19:46:12.37698 -0700 > @@ -1227,7 +1227,14 @@ > int i; >

Re: bond_compute_features() does not handle devices with different CSUM

2007-05-29 Thread Laurent Chavey
proposed change. --- 2.6.20/drivers/net/bonding/bond_main.c 2007-05-29 19:43:39.010565000 -0700 +++ 2.6.20.fix/drivers/net/bonding/bond_main.c 2007-05-29 19:46:12.37698 -0700 @@ -1227,7 +1227,14 @@ int i; bond_for_each_slave(bond, slave, i) { - features &= (

bond_compute_features() does not handle devices with different CSUM

2007-05-29 Thread Laurent Chavey
kernel version <= 2.6.20.1 file drivers/net/bonding/bonding_main.c function bond_compute_features() --- Given a system with two different NIC. One driver sets dev->features |= NETIF_F_HW_CSUM the other driver sets dev->features |= NETIF_F_IP_CSUM when enslaving the 2 d