Re: bond: take rcu lock in netpoll_send_skb_on_dev

2018-10-18 Thread Eran Ben Elisha
On 10/18/2018 8:46 AM, Cong Wang wrote: > On Mon, Oct 15, 2018 at 4:36 AM Eran Ben Elisha wrote: >> Hi, >> >> This suggested fix introduced a regression while using netconsole module >> with mlx5_core module loaded. > > It is already reported here: > https://marc.info/?l=linux-kernel&m=15391735

Re: bond: take rcu lock in netpoll_send_skb_on_dev

2018-10-17 Thread Cong Wang
On Mon, Oct 15, 2018 at 4:36 AM Eran Ben Elisha wrote: > Hi, > > This suggested fix introduced a regression while using netconsole module > with mlx5_core module loaded. It is already reported here: https://marc.info/?l=linux-kernel&m=153917359528669&w=2 > > During irq handling, we hit a warnin

Re: bond: take rcu lock in netpoll_send_skb_on_dev

2018-10-15 Thread Eran Ben Elisha
On 9/28/2018 11:26 PM, Dave Jones wrote: > The bonding driver lacks the rcu lock when it calls down into > netdev_lower_get_next_private_rcu from bond_poll_controller, which > results in a trace like: > > WARNING: CPU: 2 PID: 179 at net/core/dev.c:6567 > netdev_lower_get_next_private_rcu+0x34/0

Re: bond: take rcu lock in netpoll_send_skb_on_dev

2018-10-01 Thread David Miller
From: Dave Jones Date: Fri, 28 Sep 2018 16:26:08 -0400 > The bonding driver lacks the rcu lock when it calls down into > netdev_lower_get_next_private_rcu from bond_poll_controller, which > results in a trace like: ... > We're also doing rcu dereferences a layer up in netpoll_send_skb_on_dev > b

bond: take rcu lock in netpoll_send_skb_on_dev

2018-09-28 Thread Dave Jones
The bonding driver lacks the rcu lock when it calls down into netdev_lower_get_next_private_rcu from bond_poll_controller, which results in a trace like: WARNING: CPU: 2 PID: 179 at net/core/dev.c:6567 netdev_lower_get_next_private_rcu+0x34/0x40 CPU: 2 PID: 179 Comm: kworker/u16:15 Not tainted 4.