Re: ax25: fix possible use-after-free

2019-02-17 Thread f6bvp
Hi Eric, Yes the patch was correctly and completely applied. However, on a Raspberry Pi I am only building the AX25 module with kernel headers and without the full kernel source for debuging. After your remark I found that #include in source files did not work and I had to explicitly indicate

Re: ax25: fix possible use-after-free

2019-02-17 Thread Eric Dumazet
On 02/16/2019 02:33 PM, f6bvp wrote: > > Patch applied successfully on Linux draws-f6bvp 4.14.79-v7+ #1159 SMP Sun Nov > 4 17:50:20 GMT 2018 armv7l GNU/Linux > > However ax25_route_lock_use and ax25_route_lock_unuse() are not declared and > compile failed. > > make : on entre dans le répert

ax25: fix possible use-after-free

2019-02-16 Thread f6bvp
Patch applied successfully on Linux draws-f6bvp 4.14.79-v7+ #1159 SMP Sun Nov 4 17:50:20 GMT 2018 armv7l GNU/Linux However ax25_route_lock_use and ax25_route_lock_unuse() are not declared and compile failed. make : on entre dans le répertoire « /usr/src/linux-headers-4.14.79-v7+ » CC [M] /

[PATCH AUTOSEL 4.19 51/65] ax25: fix possible use-after-free

2019-02-14 Thread Sasha Levin
From: Eric Dumazet [ Upstream commit 63530aba7826a0f8e129874df9c4d264f9db3f9e ] syzbot found that ax25 routes where not properly protected against concurrent use [1]. In this particular report the bug happened while copying ax25->digipeat. Fix this problem by making sure we call ax25_get_route

[PATCH AUTOSEL 4.14 32/40] ax25: fix possible use-after-free

2019-02-14 Thread Sasha Levin
From: Eric Dumazet [ Upstream commit 63530aba7826a0f8e129874df9c4d264f9db3f9e ] syzbot found that ax25 routes where not properly protected against concurrent use [1]. In this particular report the bug happened while copying ax25->digipeat. Fix this problem by making sure we call ax25_get_route

[PATCH AUTOSEL 4.9 20/27] ax25: fix possible use-after-free

2019-02-14 Thread Sasha Levin
From: Eric Dumazet [ Upstream commit 63530aba7826a0f8e129874df9c4d264f9db3f9e ] syzbot found that ax25 routes where not properly protected against concurrent use [1]. In this particular report the bug happened while copying ax25->digipeat. Fix this problem by making sure we call ax25_get_route

[PATCH AUTOSEL 4.4 16/20] ax25: fix possible use-after-free

2019-02-14 Thread Sasha Levin
From: Eric Dumazet [ Upstream commit 63530aba7826a0f8e129874df9c4d264f9db3f9e ] syzbot found that ax25 routes where not properly protected against concurrent use [1]. In this particular report the bug happened while copying ax25->digipeat. Fix this problem by making sure we call ax25_get_route

[PATCH AUTOSEL 4.20 59/77] ax25: fix possible use-after-free

2019-02-14 Thread Sasha Levin
From: Eric Dumazet [ Upstream commit 63530aba7826a0f8e129874df9c4d264f9db3f9e ] syzbot found that ax25 routes where not properly protected against concurrent use [1]. In this particular report the bug happened while copying ax25->digipeat. Fix this problem by making sure we call ax25_get_route

Re: [PATCH net] ax25: fix possible use-after-free

2019-01-23 Thread Eric Dumazet
On Wed, Jan 23, 2019 at 5:12 PM Cong Wang wrote: > > On Wed, Jan 23, 2019 at 3:42 PM Eric Dumazet wrote: > > > > > > > > On 01/23/2019 03:25 PM, Cong Wang wrote: > > > On Tue, Jan 22, 2019 at 10:41 AM 'Eric Dumazet' via syzkaller > > > wrote: > > >> > > >> syzbot found that ax25 routes where not

Re: [PATCH net] ax25: fix possible use-after-free

2019-01-23 Thread Cong Wang
On Wed, Jan 23, 2019 at 3:42 PM Eric Dumazet wrote: > > > > On 01/23/2019 03:25 PM, Cong Wang wrote: > > On Tue, Jan 22, 2019 at 10:41 AM 'Eric Dumazet' via syzkaller > > wrote: > >> > >> syzbot found that ax25 routes where not properly protected > >> against concurrent use [1]. > >> > >> In this

Re: [PATCH net] ax25: fix possible use-after-free

2019-01-23 Thread Eric Dumazet
On 01/23/2019 03:25 PM, Cong Wang wrote: > On Tue, Jan 22, 2019 at 10:41 AM 'Eric Dumazet' via syzkaller > wrote: >> >> syzbot found that ax25 routes where not properly protected >> against concurrent use [1]. >> >> In this particular report the bug happened while >> copying ax25->digipeat. >>

Re: [PATCH net] ax25: fix possible use-after-free

2019-01-23 Thread Cong Wang
On Tue, Jan 22, 2019 at 10:41 AM 'Eric Dumazet' via syzkaller wrote: > > syzbot found that ax25 routes where not properly protected > against concurrent use [1]. > > In this particular report the bug happened while > copying ax25->digipeat. > > Fix this problem by making sure we call ax25_get_rout

Re: [PATCH net] ax25: fix possible use-after-free

2019-01-23 Thread David Miller
From: Eric Dumazet Date: Tue, 22 Jan 2019 10:40:59 -0800 > syzbot found that ax25 routes where not properly protected > against concurrent use [1]. > > In this particular report the bug happened while > copying ax25->digipeat. > > Fix this problem by making sure we call ax25_get_route() > while

[PATCH net] ax25: fix possible use-after-free

2019-01-22 Thread Eric Dumazet
syzbot found that ax25 routes where not properly protected against concurrent use [1]. In this particular report the bug happened while copying ax25->digipeat. Fix this problem by making sure we call ax25_get_route() while ax25_route_lock is held, so that no modification could happen while using