Re: authenc compile warnings in current net-2.6.24

2007-10-12 Thread Herbert Xu
On Fri, Oct 12, 2007 at 08:15:01AM +0200, Oliver Hartkopp wrote: > Hi Dave, > > this compile fix seems not to be applied (maybe my compiler is the only > one who complains ;-) That's because the patch is in my cryptodev-2.6 tree :) Thanks, -- Visit Openswan at http://www.openswan.org/ Email: H

Re: authenc compile warnings in current net-2.6.24

2007-10-11 Thread Oliver Hartkopp
Hi Dave, this compile fix seems not to be applied (maybe my compiler is the only one who complains ;-) Acked-by: Oliver Hartkopp <[EMAIL PROTECTED]> Thanks! On Thu, Oct 11, 2007 at 11:23:30AM +0800, Herbert Xu wrote: Yeah I've added a fix in the cryptodev tree. Oh and here's the actual

Re: authenc compile warnings in current net-2.6.24

2007-10-11 Thread Oliver Hartkopp
Sebastian Siewior wrote: * David Miller | 2007-10-10 16:25:28 [-0700]: From: Sebastian Siewior <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 21:53:37 +0200 * Oliver Hartkopp | 2007-10-10 19:53:53 [+0200]: CC [M] crypto/authenc.o crypto/authenc.c: In function ?crypto_authenc_hash

Re: authenc compile warnings in current net-2.6.24

2007-10-11 Thread Sebastian Siewior
* David Miller | 2007-10-10 16:25:28 [-0700]: >From: Sebastian Siewior <[EMAIL PROTECTED]> >Date: Wed, 10 Oct 2007 21:53:37 +0200 > >> * Oliver Hartkopp | 2007-10-10 19:53:53 [+0200]: >> >> > CC [M] crypto/authenc.o >> > crypto/authenc.c: In function ?crypto_authenc_hash?: >> > crypto/authenc.c:8

Re: authenc compile warnings in current net-2.6.24

2007-10-10 Thread Herbert Xu
On Thu, Oct 11, 2007 at 11:23:30AM +0800, Herbert Xu wrote: > > Yeah I've added a fix in the cryptodev tree. Oh and here's the actual patch. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP

Re: authenc compile warnings in current net-2.6.24

2007-10-10 Thread Herbert Xu
On Wed, Oct 10, 2007 at 04:25:28PM -0700, David Miller wrote: > > It's just not smart enough to see that cryptlen's initialization > and it's use in the auth_unlock label path are both protected > by 'err' being non-zero. > > To be honest I don't know of any compiler which commits enough > flow va

Re: authenc compile warnings in current net-2.6.24

2007-10-10 Thread David Miller
From: Sebastian Siewior <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 21:53:37 +0200 > * Oliver Hartkopp | 2007-10-10 19:53:53 [+0200]: > > > CC [M] crypto/authenc.o > > crypto/authenc.c: In function ?crypto_authenc_hash?: > > crypto/authenc.c:88: warning: ?cryptlen? may be used uninitialized in thi

Re: authenc compile warnings in current net-2.6.24

2007-10-10 Thread Sebastian Siewior
* Oliver Hartkopp | 2007-10-10 19:53:53 [+0200]: > CC [M] crypto/authenc.o > crypto/authenc.c: In function ?crypto_authenc_hash?: > crypto/authenc.c:88: warning: ?cryptlen? may be used uninitialized in this > function > crypto/authenc.c:87: warning: ?dst? may be used uninitialized in this > func

authenc compile warnings in current net-2.6.24

2007-10-10 Thread Oliver Hartkopp
Hi Herbert, CC [M] crypto/authenc.o crypto/authenc.c: In function ‘crypto_authenc_hash’: crypto/authenc.c:88: warning: ‘cryptlen’ may be used uninitialized in this function crypto/authenc.c:87: warning: ‘dst’ may be used uninitialized in this function crypto/authenc.c: In function ‘crypto_auth