Re: XDP redirect measurements, gotchas and tracepoints

2017-08-29 Thread Alexander Duyck
On Tue, Aug 29, 2017 at 12:02 PM, Andy Gospodarek wrote: > On Tue, Aug 29, 2017 at 09:23:49AM -0700, Alexander Duyck wrote: >> On Tue, Aug 29, 2017 at 6:26 AM, Jesper Dangaard Brouer >> wrote: >> > >> > On Mon, 28 Aug 2017 09:11:25 -0700 Alexander Duyck >> > wrote: >> > >> >> My advice would be

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-29 Thread Andy Gospodarek
On Tue, Aug 29, 2017 at 09:23:49AM -0700, Alexander Duyck wrote: > On Tue, Aug 29, 2017 at 6:26 AM, Jesper Dangaard Brouer > wrote: > > > > On Mon, 28 Aug 2017 09:11:25 -0700 Alexander Duyck > > wrote: > > > >> My advice would be to not over complicate this. My big concern with > >> all this buf

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-29 Thread Alexander Duyck
On Tue, Aug 29, 2017 at 6:26 AM, Jesper Dangaard Brouer wrote: > > On Mon, 28 Aug 2017 09:11:25 -0700 Alexander Duyck > wrote: > >> My advice would be to not over complicate this. My big concern with >> all this buffer recycling is what happens the first time somebody >> introduces something lik

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-29 Thread Jesper Dangaard Brouer
On Mon, 28 Aug 2017 09:11:25 -0700 Alexander Duyck wrote: > My advice would be to not over complicate this. My big concern with > all this buffer recycling is what happens the first time somebody > introduces something like mirroring? Are you going to copy the data to > a new page which would b

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-28 Thread Andy Gospodarek
On Mon, Aug 28, 2017 at 09:14:20AM -0700, John Fastabend wrote: > On 08/28/2017 09:02 AM, Andy Gospodarek wrote: > > On Fri, Aug 25, 2017 at 08:28:55AM -0700, Michael Chan wrote: > >> On Fri, Aug 25, 2017 at 8:10 AM, John Fastabend > >> wrote: > >>> On 08/25/2017 05:45 AM, Jesper Dangaard Brouer w

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-28 Thread John Fastabend
On 08/28/2017 09:02 AM, Andy Gospodarek wrote: > On Fri, Aug 25, 2017 at 08:28:55AM -0700, Michael Chan wrote: >> On Fri, Aug 25, 2017 at 8:10 AM, John Fastabend >> wrote: >>> On 08/25/2017 05:45 AM, Jesper Dangaard Brouer wrote: On Thu, 24 Aug 2017 20:36:28 -0700 Michael Chan wrote: >>

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-28 Thread Alexander Duyck
On Mon, Aug 28, 2017 at 9:02 AM, Andy Gospodarek wrote: > On Fri, Aug 25, 2017 at 08:28:55AM -0700, Michael Chan wrote: >> On Fri, Aug 25, 2017 at 8:10 AM, John Fastabend >> wrote: >> > On 08/25/2017 05:45 AM, Jesper Dangaard Brouer wrote: >> >> On Thu, 24 Aug 2017 20:36:28 -0700 >> >> Michael Ch

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-28 Thread Andy Gospodarek
On Fri, Aug 25, 2017 at 08:28:55AM -0700, Michael Chan wrote: > On Fri, Aug 25, 2017 at 8:10 AM, John Fastabend > wrote: > > On 08/25/2017 05:45 AM, Jesper Dangaard Brouer wrote: > >> On Thu, 24 Aug 2017 20:36:28 -0700 > >> Michael Chan wrote: > >> > >>> On Wed, Aug 23, 2017 at 1:29 AM, Jesper Da

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-25 Thread Michael Chan
On Fri, Aug 25, 2017 at 8:10 AM, John Fastabend wrote: > On 08/25/2017 05:45 AM, Jesper Dangaard Brouer wrote: >> On Thu, 24 Aug 2017 20:36:28 -0700 >> Michael Chan wrote: >> >>> On Wed, Aug 23, 2017 at 1:29 AM, Jesper Dangaard Brouer >>> wrote: On Tue, 22 Aug 2017 23:59:05 -0700 Micha

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-25 Thread John Fastabend
On 08/25/2017 05:45 AM, Jesper Dangaard Brouer wrote: > On Thu, 24 Aug 2017 20:36:28 -0700 > Michael Chan wrote: > >> On Wed, Aug 23, 2017 at 1:29 AM, Jesper Dangaard Brouer >> wrote: >>> On Tue, 22 Aug 2017 23:59:05 -0700 >>> Michael Chan wrote: >>> On Tue, Aug 22, 2017 at 6:06 PM, Alex

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-25 Thread Jesper Dangaard Brouer
On Thu, 24 Aug 2017 20:36:28 -0700 Michael Chan wrote: > On Wed, Aug 23, 2017 at 1:29 AM, Jesper Dangaard Brouer > wrote: > > On Tue, 22 Aug 2017 23:59:05 -0700 > > Michael Chan wrote: > > > >> On Tue, Aug 22, 2017 at 6:06 PM, Alexander Duyck > >> wrote: > >> > On Tue, Aug 22, 2017 at 1:04

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-24 Thread Michael Chan
On Wed, Aug 23, 2017 at 1:29 AM, Jesper Dangaard Brouer wrote: > On Tue, 22 Aug 2017 23:59:05 -0700 > Michael Chan wrote: > >> On Tue, Aug 22, 2017 at 6:06 PM, Alexander Duyck >> wrote: >> > On Tue, Aug 22, 2017 at 1:04 PM, Michael Chan >> > wrote: >> >> >> >> Right, but it's conceivable to ad

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-23 Thread Alexander Duyck
On Tue, Aug 22, 2017 at 11:59 PM, Michael Chan wrote: > On Tue, Aug 22, 2017 at 6:06 PM, Alexander Duyck > wrote: >> On Tue, Aug 22, 2017 at 1:04 PM, Michael Chan >> wrote: >>> >>> Right, but it's conceivable to add an API to "return" the buffer to >>> the input device, right? >> >> You could,

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-23 Thread Jesper Dangaard Brouer
On Tue, 22 Aug 2017 10:17:59 -0700 John Fastabend wrote: > On 08/22/2017 10:09 AM, Alexei Starovoitov wrote: > > On Tue, Aug 22, 2017 at 08:37:10AM +0200, Jesper Dangaard Brouer wrote: > >> > >> > >>> Once tx-ing netdev added to devmap we can enable xdp on it automatically? > >>> > >> > >>

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-23 Thread Jesper Dangaard Brouer
On Tue, 22 Aug 2017 23:59:05 -0700 Michael Chan wrote: > On Tue, Aug 22, 2017 at 6:06 PM, Alexander Duyck > wrote: > > On Tue, Aug 22, 2017 at 1:04 PM, Michael Chan > > wrote: > >> > >> Right, but it's conceivable to add an API to "return" the buffer to > >> the input device, right? Yes, I

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-22 Thread Michael Chan
On Tue, Aug 22, 2017 at 6:06 PM, Alexander Duyck wrote: > On Tue, Aug 22, 2017 at 1:04 PM, Michael Chan > wrote: >> >> Right, but it's conceivable to add an API to "return" the buffer to >> the input device, right? > > You could, it is just added complexity. "just free the buffer" in > ixgbe usu

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-22 Thread Alexander Duyck
On Tue, Aug 22, 2017 at 1:04 PM, Michael Chan wrote: > On Tue, Aug 22, 2017 at 11:30 AM, Duyck, Alexander H > wrote: >> On Tue, 2017-08-22 at 11:17 -0700, John Fastabend wrote: >>> On 08/22/2017 11:02 AM, Michael Chan wrote: >>> > On Mon, Aug 21, 2017 at 12:25 PM, Jesper Dangaard Brouer >>> > wr

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-22 Thread Michael Chan
On Tue, Aug 22, 2017 at 11:30 AM, Duyck, Alexander H wrote: > On Tue, 2017-08-22 at 11:17 -0700, John Fastabend wrote: >> On 08/22/2017 11:02 AM, Michael Chan wrote: >> > On Mon, Aug 21, 2017 at 12:25 PM, Jesper Dangaard Brouer >> > wrote: >> > > >> > > I'be been playing with the latest XDP_REDIR

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-22 Thread Duyck, Alexander H
On Tue, 2017-08-22 at 11:17 -0700, John Fastabend wrote: > On 08/22/2017 11:02 AM, Michael Chan wrote: > > On Mon, Aug 21, 2017 at 12:25 PM, Jesper Dangaard Brouer > > wrote: > > > > > > I'be been playing with the latest XDP_REDIRECT feature, that was > > > accepted in net-next (for ixgbe), see m

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-22 Thread John Fastabend
On 08/22/2017 11:02 AM, Michael Chan wrote: > On Mon, Aug 21, 2017 at 12:25 PM, Jesper Dangaard Brouer > wrote: >> >> I'be been playing with the latest XDP_REDIRECT feature, that was >> accepted in net-next (for ixgbe), see merge commit[1]. >> [1] https://git.kernel.org/davem/net-next/c/6093ec2dc

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-22 Thread Michael Chan
On Mon, Aug 21, 2017 at 12:25 PM, Jesper Dangaard Brouer wrote: > > I'be been playing with the latest XDP_REDIRECT feature, that was > accepted in net-next (for ixgbe), see merge commit[1]. > [1] https://git.kernel.org/davem/net-next/c/6093ec2dc31 > Just catching on XDP_REDIRECT and I have a ver

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-22 Thread John Fastabend
On 08/22/2017 10:09 AM, Alexei Starovoitov wrote: > On Tue, Aug 22, 2017 at 08:37:10AM +0200, Jesper Dangaard Brouer wrote: >> >> >>> Once tx-ing netdev added to devmap we can enable xdp on it automatically? >> >> I think you are referring to Gotcha-2 here: > > oops. yes :) > >> >> Second gotch

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-22 Thread Alexei Starovoitov
On Tue, Aug 22, 2017 at 08:37:10AM +0200, Jesper Dangaard Brouer wrote: > > > > Once tx-ing netdev added to devmap we can enable xdp on it automatically? > > I think you are referring to Gotcha-2 here: oops. yes :) > > Second gotcha(2): you cannot TX out a device, unless it also have a >

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-21 Thread Jesper Dangaard Brouer
On Mon, 21 Aug 2017 15:35:42 -0700 Alexei Starovoitov wrote: > On Mon, Aug 21, 2017 at 09:25:06PM +0200, Jesper Dangaard Brouer wrote: > > > > Third gotcha(3): You got this far, loaded xdp on both interfaces, and > > notice now that (with default setup) you can RX with 14Mpps but only > > TX wit

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-21 Thread Alexei Starovoitov
On Mon, Aug 21, 2017 at 09:25:06PM +0200, Jesper Dangaard Brouer wrote: > > Third gotcha(3): You got this far, loaded xdp on both interfaces, and > notice now that (with default setup) you can RX with 14Mpps but only > TX with 6.9Mpps (and might have 5% idle cycles). I debugged this via > perf tr

XDP redirect measurements, gotchas and tracepoints

2017-08-21 Thread Jesper Dangaard Brouer
I'be been playing with the latest XDP_REDIRECT feature, that was accepted in net-next (for ixgbe), see merge commit[1]. [1] https://git.kernel.org/davem/net-next/c/6093ec2dc31 At a first glance the performance looks awesome, and it is(!) when your system is tuned for this workload. When perfectl