Re: WARNING in __rcu_read_unlock

2018-12-18 Thread Cong Wang
On Tue, Dec 18, 2018 at 4:40 AM Stefano Brivio wrote: > Not as far as I know. The selftests checking this path, by design, only > use supported configurations, they don't forge packets. > > Maybe it would be nice to have a semi-automated way to isolate and > describe/name specific conditions found

Re: WARNING in __rcu_read_unlock

2018-12-18 Thread Dmitry Vyukov
On Tue, Dec 18, 2018 at 3:13 PM Stefano Brivio wrote: > > [Dropping syzbot from Cc:] > > On Tue, 18 Dec 2018 14:26:00 +0100 > Dmitry Vyukov wrote: > > > On Tue, Dec 18, 2018 at 1:40 PM Stefano Brivio > > wrote: > > > > > Maybe it would be nice to have a semi-automated way to isolate and > > > de

Re: WARNING in __rcu_read_unlock

2018-12-18 Thread Stefano Brivio
[Dropping syzbot from Cc:] On Tue, 18 Dec 2018 14:26:00 +0100 Dmitry Vyukov wrote: > On Tue, Dec 18, 2018 at 1:40 PM Stefano Brivio > wrote: > > > Maybe it would be nice to have a semi-automated way to isolate and > > describe/name specific conditions found by syzbot via fuzzing and > > turn th

Re: WARNING in __rcu_read_unlock

2018-12-18 Thread Paul E. McKenney
On Tue, Dec 18, 2018 at 02:26:00PM +0100, Dmitry Vyukov wrote: > On Tue, Dec 18, 2018 at 1:40 PM Stefano Brivio wrote: > > > > On Tue, 18 Dec 2018 09:49:17 +0100 > > Dmitry Vyukov wrote: > > > > > On Tue, Dec 18, 2018 at 12:18 AM Stefano Brivio > > > wrote: > > > > > > > > On Mon, 17 Dec 2018 1

Re: WARNING in __rcu_read_unlock

2018-12-18 Thread Dmitry Vyukov
On Tue, Dec 18, 2018 at 1:40 PM Stefano Brivio wrote: > > On Tue, 18 Dec 2018 09:49:17 +0100 > Dmitry Vyukov wrote: > > > On Tue, Dec 18, 2018 at 12:18 AM Stefano Brivio wrote: > > > > > > On Mon, 17 Dec 2018 16:53:36 +0100 > > > Dmitry Vyukov wrote: > > > > > > > On Mon, Dec 17, 2018 at 4:24 P

Re: WARNING in __rcu_read_unlock

2018-12-18 Thread Stefano Brivio
On Tue, 18 Dec 2018 09:49:17 +0100 Dmitry Vyukov wrote: > On Tue, Dec 18, 2018 at 12:18 AM Stefano Brivio wrote: > > > > On Mon, 17 Dec 2018 16:53:36 +0100 > > Dmitry Vyukov wrote: > > > > > On Mon, Dec 17, 2018 at 4:24 PM Stefano Brivio > > > wrote: > > > > > > > > On Mon, 17 Dec 2018 06

Re: WARNING in __rcu_read_unlock

2018-12-18 Thread Dmitry Vyukov
On Tue, Dec 18, 2018 at 12:18 AM Stefano Brivio wrote: > > On Mon, 17 Dec 2018 16:53:36 +0100 > Dmitry Vyukov wrote: > > > On Mon, Dec 17, 2018 at 4:24 PM Stefano Brivio wrote: > > > > > > On Mon, 17 Dec 2018 06:57:35 -0800 > > > Eric Dumazet wrote: > > > > > > > Might be cause by commit b8a51b

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Stefano Brivio
On Mon, 17 Dec 2018 16:53:36 +0100 Dmitry Vyukov wrote: > On Mon, Dec 17, 2018 at 4:24 PM Stefano Brivio wrote: > > > > On Mon, 17 Dec 2018 06:57:35 -0800 > > Eric Dumazet wrote: > > > > > Might be cause by commit b8a51b38e4d4dec3e379d52c0fe1a66827f7cf1e > > > fou, fou6: ICMP error handlers f

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Paul E. McKenney
On Mon, Dec 17, 2018 at 07:45:58PM +0100, Dmitry Vyukov wrote: > On Mon, Dec 17, 2018 at 12:29 PM Paul E. McKenney > wrote: > > Any chance of a bisection? > > Better later then never. Bisection also needs testing :) Well, it looks like it did pass the test, arriving at the same commit that Eric

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Dmitry Vyukov
On Mon, Dec 17, 2018 at 12:29 PM Paul E. McKenney wrote: > Any chance of a bisection? Better later then never. Bisection also needs testing :) syz-bisect -config bisect.cfg -crash dda626cdbd87eafe9a755acbbe102e2b6096b256 searching for guilty commit starting from 2aa55dccf83d building syzkaller o

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Stefano Brivio
On Mon, 17 Dec 2018 16:24:21 +0100 Stefano Brivio wrote: > On Mon, 17 Dec 2018 06:57:35 -0800 > Eric Dumazet wrote: > > > Might be cause by commit b8a51b38e4d4dec3e379d52c0fe1a66827f7cf1e > > fou, fou6: ICMP error handlers for FoU and GUE > > This: > > diff --git a/net/ipv4/fou.c b/net/ipv4

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Dmitry Vyukov
On Mon, Dec 17, 2018 at 4:24 PM Stefano Brivio wrote: > > On Mon, 17 Dec 2018 06:57:35 -0800 > Eric Dumazet wrote: > > > Might be cause by commit b8a51b38e4d4dec3e379d52c0fe1a66827f7cf1e > > fou, fou6: ICMP error handlers for FoU and GUE > > This: > > diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Stefano Brivio
On Mon, 17 Dec 2018 06:57:35 -0800 Eric Dumazet wrote: > Might be cause by commit b8a51b38e4d4dec3e379d52c0fe1a66827f7cf1e > fou, fou6: ICMP error handlers for FoU and GUE This: diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c index 0d0ad19ecb87..20a6de26d146 100644 --- a/net/ipv4/fou.c +++ b/net/i

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Dmitry Vyukov
On Mon, Dec 17, 2018 at 4:00 PM Stefano Brivio wrote: > > On Mon, 17 Dec 2018 06:57:35 -0800 > Eric Dumazet wrote: > > > Might be cause by commit b8a51b38e4d4dec3e379d52c0fe1a66827f7cf1e > > fou, fou6: ICMP error handlers for FoU and GUE > > Most likely, yes. > > > Please Stefano take a look, tha

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Stefano Brivio
On Mon, 17 Dec 2018 06:57:35 -0800 Eric Dumazet wrote: > Might be cause by commit b8a51b38e4d4dec3e379d52c0fe1a66827f7cf1e > fou, fou6: ICMP error handlers for FoU and GUE Most likely, yes. > Please Stefano take a look, thanks ! Started one minute before your email, thanks for Cc'ing me though

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Eric Dumazet
On 12/17/2018 06:40 AM, Dmitry Vyukov wrote: > On Mon, Dec 17, 2018 at 3:14 PM Arjan van de Ven > wrote: >> >> On 12/17/2018 3:29 AM, Paul E. McKenney wrote: >>> As does this sort of report on a line that contains simple integer >>> arithmetic and boolean operations.;-) >>> >>> Any chance of a

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Paul E. McKenney
On Mon, Dec 17, 2018 at 03:40:06PM +0100, Dmitry Vyukov wrote: > On Mon, Dec 17, 2018 at 3:14 PM Arjan van de Ven > wrote: > > > > On 12/17/2018 3:29 AM, Paul E. McKenney wrote: > > > As does this sort of report on a line that contains simple integer > > > arithmetic and boolean operations.;-) >

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Dmitry Vyukov
On Mon, Dec 17, 2018 at 3:14 PM Arjan van de Ven wrote: > > On 12/17/2018 3:29 AM, Paul E. McKenney wrote: > > As does this sort of report on a line that contains simple integer > > arithmetic and boolean operations.;-) > > > > Any chance of a bisection? > > btw this looks like something caused a

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Arjan van de Ven
On 12/17/2018 3:29 AM, Paul E. McKenney wrote: As does this sort of report on a line that contains simple integer arithmetic and boolean operations.;-) Any chance of a bisection? btw this looks like something caused a stack overflow and thus all the weirdness that then happens

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Dmitry Vyukov
On Mon, Dec 17, 2018 at 12:29 PM Paul E. McKenney wrote: > > On Mon, Dec 17, 2018 at 10:44:52AM +0100, Dmitry Vyukov wrote: > > On Sun, Dec 16, 2018 at 8:04 PM Paul E. McKenney > > wrote: > > > > > > On Sat, Dec 15, 2018 at 04:41:03AM -0800, syzbot wrote: > > > > Hello, > > > > > > > > syzbot fo

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Paul E. McKenney
On Mon, Dec 17, 2018 at 10:44:52AM +0100, Dmitry Vyukov wrote: > On Sun, Dec 16, 2018 at 8:04 PM Paul E. McKenney > wrote: > > > > On Sat, Dec 15, 2018 at 04:41:03AM -0800, syzbot wrote: > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:2aa55dccf83d hns3: p

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Dmitry Vyukov
On Sun, Dec 16, 2018 at 8:04 PM Paul E. McKenney wrote: > > On Sat, Dec 15, 2018 at 04:41:03AM -0800, syzbot wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:2aa55dccf83d hns3: prevent building without CONFIG_INET > > git tree: net-next > > console outpu