Re: WARNING: refcount bug in should_fail

2018-04-21 Thread Tetsuo Handa
Eric W. Biederman wrote: > Al Viro writes: > > > On Mon, Apr 02, 2018 at 10:59:34PM +0100, Al Viro wrote: > > > >> FWIW, I'm going through the ->kill_sb() instances, fixing that sort > >> of bugs (most of them preexisting, but I should've checked instead > >> of assuming that everything's fine).

Re: WARNING: refcount bug in should_fail

2018-04-04 Thread Eric W. Biederman
Al Viro writes: > On Mon, Apr 02, 2018 at 10:59:34PM +0100, Al Viro wrote: > >> FWIW, I'm going through the ->kill_sb() instances, fixing that sort >> of bugs (most of them preexisting, but I should've checked instead >> of assuming that everything's fine). Will push out later tonight. > > OK, s

Re: WARNING: refcount bug in should_fail

2018-04-03 Thread Dmitry Vyukov
On Tue, Apr 3, 2018 at 7:20 AM, Al Viro wrote: > On Mon, Apr 02, 2018 at 10:59:34PM +0100, Al Viro wrote: > >> FWIW, I'm going through the ->kill_sb() instances, fixing that sort >> of bugs (most of them preexisting, but I should've checked instead >> of assuming that everything's fine). Will pus

Re: WARNING: refcount bug in should_fail

2018-04-02 Thread Al Viro
On Mon, Apr 02, 2018 at 10:59:34PM +0100, Al Viro wrote: > FWIW, I'm going through the ->kill_sb() instances, fixing that sort > of bugs (most of them preexisting, but I should've checked instead > of assuming that everything's fine). Will push out later tonight. OK, see vfs.git#for-linus. Caug

Re: WARNING: refcount bug in should_fail

2018-04-02 Thread Al Viro
On Mon, Apr 02, 2018 at 10:52:12PM +0100, Al Viro wrote: > On Mon, Apr 02, 2018 at 03:30:56PM -0500, Eric W. Biederman wrote: > > Tetsuo Handa writes: > > > > I don't think this is a dup of existing bug. > > > We need to fix either 9ee332d99e4d5a97 or d91ee87d8d85a080. > > > > Even if expanding

Re: WARNING: refcount bug in should_fail

2018-04-02 Thread Al Viro
On Mon, Apr 02, 2018 at 03:30:56PM -0500, Eric W. Biederman wrote: > Tetsuo Handa writes: > > I don't think this is a dup of existing bug. > > We need to fix either 9ee332d99e4d5a97 or d91ee87d8d85a080. > > Even if expanding mount_ns to more filesystems was magically fixed, > proc would still ha

Re: WARNING: refcount bug in should_fail

2018-04-02 Thread Eric W. Biederman
Tetsuo Handa writes: > syzbot wrote: >> > On Sun, Mar 4, 2018 at 6:57 AM, Tetsuo Handa >> > wrote: >> >> Switching from mm to fsdevel, for this report says that put_net(net) in >> >> rpc_kill_sb() made net->count < 0 when mount_ns() failed due to >> >> register_shrinker() failure. >> >> >> Rele

Re: WARNING: refcount bug in should_fail

2018-04-01 Thread Dmitry Vyukov
versus rpc_fill_super(). >>> I think we need to fix either 9ee332d99e4d5a97 or d91ee87d8d85a080. >> >> Hi, >> >> I think I was looking at this incarnation of this bug before marking it as >> dup: >> https://syzkaller.appspot.com/text?tag=CrashReport&

Re: WARNING: refcount bug in should_fail

2018-04-01 Thread Dmitry Vyukov
On Sun, Apr 1, 2018 at 1:30 PM, Dmitry Vyukov wrote: > On Sun, Apr 1, 2018 at 1:11 PM, Tetsuo Handa > wrote: >> Dmitry Vyukov wrote: >>> On Sun, Apr 1, 2018 at 12:32 PM, Dmitry Vyukov wrote: >>> > On Sun, Mar 4, 2018 at 6:57 AM, Tetsuo Handa >>> > wrote: >>> >> Switching from mm to fsdevel, for

Re: WARNING: refcount bug in should_fail

2018-04-01 Thread Dmitry Vyukov
On Sun, Apr 1, 2018 at 1:11 PM, Tetsuo Handa wrote: > Dmitry Vyukov wrote: >> On Sun, Apr 1, 2018 at 12:32 PM, Dmitry Vyukov wrote: >> > On Sun, Mar 4, 2018 at 6:57 AM, Tetsuo Handa >> > wrote: >> >> Switching from mm to fsdevel, for this report says that put_net(net) in >> >> rpc_kill_sb() made

Re: WARNING: refcount bug in should_fail

2018-04-01 Thread Tetsuo Handa
Dmitry Vyukov wrote: > On Sun, Apr 1, 2018 at 12:32 PM, Dmitry Vyukov wrote: > > On Sun, Mar 4, 2018 at 6:57 AM, Tetsuo Handa > > wrote: > >> Switching from mm to fsdevel, for this report says that put_net(net) in > >> rpc_kill_sb() made net->count < 0 when mount_ns() failed due to > >> register_

Re: WARNING: refcount bug in should_fail

2018-04-01 Thread Tetsuo Handa
syzbot wrote: > > On Sun, Mar 4, 2018 at 6:57 AM, Tetsuo Handa > > wrote: > >> Switching from mm to fsdevel, for this report says that put_net(net) in > >> rpc_kill_sb() made net->count < 0 when mount_ns() failed due to > >> register_shrinker() failure. > > >> Relevant commits will be > >> commit

Re: WARNING: refcount bug in should_fail

2018-04-01 Thread Dmitry Vyukov
On Sun, Apr 1, 2018 at 12:32 PM, Dmitry Vyukov wrote: > On Sun, Mar 4, 2018 at 6:57 AM, Tetsuo Handa > wrote: >> Switching from mm to fsdevel, for this report says that put_net(net) in >> rpc_kill_sb() made net->count < 0 when mount_ns() failed due to >> register_shrinker() failure. >> >> Relevan

Re: Re: WARNING: refcount bug in should_fail

2018-04-01 Thread syzbot
On Sun, Mar 4, 2018 at 6:57 AM, Tetsuo Handa wrote: Switching from mm to fsdevel, for this report says that put_net(net) in rpc_kill_sb() made net->count < 0 when mount_ns() failed due to register_shrinker() failure. Relevant commits will be commit 9ee332d99e4d5a97 ("sget(): handle failures o

Re: WARNING: refcount bug in should_fail

2018-04-01 Thread Dmitry Vyukov
On Sun, Mar 4, 2018 at 6:57 AM, Tetsuo Handa wrote: > Switching from mm to fsdevel, for this report says that put_net(net) in > rpc_kill_sb() made net->count < 0 when mount_ns() failed due to > register_shrinker() failure. > > Relevant commits will be > commit 9ee332d99e4d5a97 ("sget(): handle fai

Re: WARNING: refcount bug in should_fail

2018-03-03 Thread Tetsuo Handa
Switching from mm to fsdevel, for this report says that put_net(net) in rpc_kill_sb() made net->count < 0 when mount_ns() failed due to register_shrinker() failure. Relevant commits will be commit 9ee332d99e4d5a97 ("sget(): handle failures of register_shrinker()") and commit d91ee87d8d85a080 ("vfs