Re: UDP data corruption in v4.4

2020-07-27 Thread Eric Dumazet
On 7/27/20 11:57 AM, Dexuan Cui wrote: >> From: Eric Dumazet > Oh, yes! :-) Thank you! > > Eric, I'll add your Signed-off-by and mine. Please let me know in case > this is not ok. Sure, do not worry about this. > > I'll do a little more testing with the patch and I plan to post the patch >

RE: UDP data corruption in v4.4

2020-07-27 Thread Dexuan Cui
> From: Eric Dumazet > Sent: Monday, July 27, 2020 11:40 AM > To: Dexuan Cui > > On Mon, Jul 27, 2020 at 11:38 AM Dexuan Cui wrote: > > > > > From: Greg KH > > > Sent: Friday, July 24, 2020 10:59 PM > > > > [...] > > > > Eric Dumazet made an alternative that performs the csum validation > earl

RE: UDP data corruption in v4.4

2020-07-27 Thread Dexuan Cui
> From: Greg KH > Sent: Friday, July 24, 2020 10:59 PM > > [...] > > Eric Dumazet made an alternative that performs the csum validation earlier: > > > > --- a/net/ipv4/udp.c > > +++ b/net/ipv4/udp.c > > @@ -1589,8 +1589,7 @@ int udp_queue_rcv_skb(struct sock *sk, struct > > sk_buff *skb) > >

Re: UDP data corruption in v4.4

2020-07-24 Thread Greg KH
On Sat, Jul 25, 2020 at 02:21:06AM +, Dexuan Cui wrote: > Hi, > The v4.4 stable kernel (currently it's v4.4.231) lacks this bugfix: > 327868212381 ("make skb_copy_datagram_msg() et.al. preserve ->msg_iter on > error") > , as a result, the v4.4 kernel can deliver corrupt data to the application

UDP data corruption in v4.4

2020-07-24 Thread Dexuan Cui
Hi, The v4.4 stable kernel (currently it's v4.4.231) lacks this bugfix: 327868212381 ("make skb_copy_datagram_msg() et.al. preserve ->msg_iter on error") , as a result, the v4.4 kernel can deliver corrupt data to the application when a corrupt UDP packet is closely followed by a valid UDP packet: