Re: UBSAN: object-size-mismatch in wg_xmit

2021-01-11 Thread Jeffrey Walton
On Mon, Jan 11, 2021 at 12:58 PM Dmitry Vyukov wrote: > > On Mon, Jan 11, 2021 at 6:35 PM Jeffrey Walton wrote: > > > > On Mon, Jan 11, 2021 at 12:20 PM Dmitry Vyukov wrote: > > > ... > > > FTR, I've disabled the following UBSAN configs: > > > UBSAN_MISC > > > UBSAN_DIV_ZERO > > > UBSAN_BOOL > >

Re: UBSAN: object-size-mismatch in wg_xmit

2021-01-11 Thread Jeffrey Walton
On Mon, Jan 11, 2021 at 12:20 PM Dmitry Vyukov wrote: > ... > FTR, I've disabled the following UBSAN configs: > UBSAN_MISC > UBSAN_DIV_ZERO > UBSAN_BOOL > UBSAN_OBJECT_SIZE > UBSAN_SIGNED_OVERFLOW > UBSAN_UNSIGNED_OVERFLOW > UBSAN_ENUM > UBSAN_ALIGNMENT > UBSAN_UNREACHABLE > > Only these are enabl

Re: UBSAN: object-size-mismatch in wg_xmit

2021-01-08 Thread Nathan Chancellor
On Fri, Jan 08, 2021 at 10:33:19AM +0100, Dmitry Vyukov wrote: > On Thu, Jan 7, 2021 at 8:06 PM Jeffrey Walton wrote: > > > > On Thu, Jan 7, 2021 at 2:03 PM Jason A. Donenfeld wrote: > > > > > > On Thu, Jan 7, 2021 at 1:22 PM Dmitry Vyukov wrote: > > > > > > > > On Mon, Dec 21, 2020 at 12:23 PM

Re: UBSAN: object-size-mismatch in wg_xmit

2021-01-07 Thread Corey Costello
Get me off this fucking list ffs. > On Jan 7, 2021, at 2:06 PM, Jeffrey Walton wrote: > > On Thu, Jan 7, 2021 at 2:03 PM Jason A. Donenfeld wrote: >> >> On Thu, Jan 7, 2021 at 1:22 PM Dmitry Vyukov wrote: >>> >>> On Mon, Dec 21, 2020 at 12:23 PM Jason A. Donenfeld wrote: ... >>

Re: UBSAN: object-size-mismatch in wg_xmit

2021-01-07 Thread Jeffrey Walton
On Thu, Jan 7, 2021 at 2:03 PM Jason A. Donenfeld wrote: > > On Thu, Jan 7, 2021 at 1:22 PM Dmitry Vyukov wrote: > > > > On Mon, Dec 21, 2020 at 12:23 PM Jason A. Donenfeld wrote: > > > > > > ... > > > > These UBSAN checks were just enabled recently. > > It's indeed super easy to trigger: 133083

Re: UBSAN: object-size-mismatch in wg_xmit

2021-01-07 Thread Julian Wiedmann
On 21.12.20 12:23, Jason A. Donenfeld wrote: > Hi Dmitry, > ... > fall on the border of a mapping? Is UBSAN non-deterministic as an > optimization? Or is there actually some mysterious UaF happening with > my usage of skbs that I shouldn't overlook? > One oddity is that wg_xmit() returns negat

Re: UBSAN: object-size-mismatch in wg_xmit

2020-12-21 Thread Jason A. Donenfeld
Hi Dmitry, On Mon, Dec 21, 2020 at 10:14 AM Dmitry Vyukov wrote: > Hi Jason, > > Thanks for looking into this. > > Reading clang docs for ubsan: > > https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html > -fsanitize=object-size: An attempt to potentially use bytes which the > optimizer can

Re: UBSAN: object-size-mismatch in wg_xmit

2020-12-20 Thread Jason A. Donenfeld
Hmm, on first glance, I'm not sure I'm seeing the bug: On Sun, Dec 20, 2020 at 5:54 PM syzbot wrote: > UBSAN: object-size-mismatch in ./include/linux/skbuff.h:2021:28 > member access within address 85889cc2 with insufficient space > for an object of type 'struct sk_buff' > __skb_queue_be

UBSAN: object-size-mismatch in wg_xmit

2020-12-20 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:5e60366d Merge tag 'fallthrough-fixes-clang-5.11-rc1' of g.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=12b12c1350 kernel config: https://syzkaller.appspot.com/x/.config?x=267a60b188ded8ed das