Re: Two comments on the H.323 conntrack/NAT helper

2006-03-24 Thread Jing Min Zhao
9:02 PM Subject: Re: Two comments on the H.323 conntrack/NAT helper [The hotmail address of the author doesn't work, CCed sourceforge-address] Adrian Bunk wrote: Two comments on the H.323 conntrack/NAT helper: - the function prototypes in ip_nat_helper_h323.c are _ugly_, please move the

Re: Two comments on the H.323 conntrack/NAT helper

2006-03-23 Thread Jing Min Zhao
9:02 PM Subject: Re: Two comments on the H.323 conntrack/NAT helper [The hotmail address of the author doesn't work, CCed sourceforge-address] Adrian Bunk wrote: Two comments on the H.323 conntrack/NAT helper: - the function prototypes in ip_nat_helper_h323.c are _ugly_, please move the

Re: Two comments on the H.323 conntrack/NAT helper

2006-03-23 Thread Jing Min Zhao
- Original Message - From: "Adrian Bunk" <[EMAIL PROTECTED]> To: "Jing Min Zhao" <[EMAIL PROTECTED]> Cc: ; <[EMAIL PROTECTED]>; Sent: Thursday, March 23, 2006 7:13 PM Subject: Two comments on the H.323 conntrack/NAT helper Two comments on

Re: Two comments on the H.323 conntrack/NAT helper

2006-03-23 Thread Patrick McHardy
[The hotmail address of the author doesn't work, CCed sourceforge-address] Adrian Bunk wrote: > Two comments on the H.323 conntrack/NAT helper: > - the function prototypes in ip_nat_helper_h323.c are _ugly_, > please move them to a header file Their ugliness is because of t

Two comments on the H.323 conntrack/NAT helper

2006-03-23 Thread Adrian Bunk
Two comments on the H.323 conntrack/NAT helper: - the function prototypes in ip_nat_helper_h323.c are _ugly_, please move them to a header file - is there a reason for not using EXPORT_SYMBOL_GPL? cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out