Re: Suspicious fackets_out handling

2007-07-02 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Fri, 1 Jun 2007 15:17:00 +0300 (EEST) > On Thu, 31 May 2007, David Miller wrote: > > > Is it possible to update fastpath_cnt_hint properly perhaps? > > I think that would be valid and even accurate as it can checks skb's > seq against fastpath_skb_

Re: Suspicious fackets_out handling

2007-06-01 Thread Ilpo Järvinen
On Thu, 31 May 2007, David Miller wrote: > From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> > Date: Mon, 23 Apr 2007 14:28:21 +0300 (EEST) > > > There are IMHO two problems in it. First of all, nothing ensures that the > > skb TCP is fragmenting is actually below the forwardmost sack block (and > > th

Re: Suspicious fackets_out handling

2007-05-31 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 23 Apr 2007 14:28:21 +0300 (EEST) > There are IMHO two problems in it. First of all, nothing ensures that the > skb TCP is fragmenting is actually below the forwardmost sack block (and > thus is included to the fackets_out)... Good catch, I a

Suspicious fackets_out handling

2007-04-23 Thread Ilpo Järvinen
Hi, While looking through the users of fackets_out, i found this from tcp_fragment(...): /* If this packet has been sent out already, we must * adjust the various packet counters. */ if (!before(tp->snd_nxt, TCP_SKB_CB(buff)->end_seq)) { int dif