Re: Setting skb->csum in shared skb with csum-complete

2017-01-19 Thread Tom Herbert
On Thu, Jan 19, 2017 at 6:00 PM, Eric Dumazet wrote: > On Thu, 2017-01-19 at 17:29 -0800, Tom Herbert wrote: >> Hi Herbert, >> >> I am looking at "net: Fix skb csum races when peeking". The context is >> that I'm seeing checksum faults after backporting mlx5 from driver. >> The handling of the che

Re: Setting skb->csum in shared skb with csum-complete

2017-01-19 Thread Eric Dumazet
On Thu, 2017-01-19 at 17:29 -0800, Tom Herbert wrote: > Hi Herbert, > > I am looking at "net: Fix skb csum races when peeking". The context is > that I'm seeing checksum faults after backporting mlx5 from driver. > The handling of the checksum faults in interesting in itself. One side > effect is

Setting skb->csum in shared skb with csum-complete

2017-01-19 Thread Tom Herbert
Hi Herbert, I am looking at "net: Fix skb csum races when peeking". The context is that I'm seeing checksum faults after backporting mlx5 from driver. The handling of the checksum faults in interesting in itself. One side effect is that we end up recalculating and doing the dump twice when GRO is