Re: SWS for rcvbuf < MTU

2007-04-02 Thread David Miller
From: Alex Sidorenko <[EMAIL PROTECTED]> Date: Mon, 2 Apr 2007 16:01:13 -0400 > our customer has tested your patch thoroughly and everything's working fine. > Please apply the patch if this is not done yet. Thanks for following through on this Alex, I've been waiting patiently for your test resu

Re: SWS for rcvbuf < MTU

2007-04-02 Thread Alex Sidorenko
On March 14, 2007 12:18:56 pm Alex Sidorenko wrote: > On March 13, 2007 03:01:50 pm John Heffner wrote: > > Sorry for the long delay in response, I've been on vacation.  I'm okay > > with your patch, and I can't think of any real problem with it, except > > that the behavior is non-standard.  Then

Re: SWS for rcvbuf < MTU

2007-03-14 Thread Alex Sidorenko
On March 13, 2007 03:01:50 pm John Heffner wrote: > Sorry for the long delay in response, I've been on vacation.  I'm okay > with your patch, and I can't think of any real problem with it, except > that the behavior is non-standard.  Then again, Linux acking in general > is non-standard, which has

Re: SWS for rcvbuf < MTU

2007-03-13 Thread John Heffner
Alex Sidorenko wrote: Here are the values from live kernel (obtained with 'crash') when the host was in SWS state: full_space=708 full_space/2=354 free_space=393 window=76 In this case the test from my original fix, (window < full_space/2), succeeds. But John's test free_space > w

Re: SWS for rcvbuf < MTU

2007-03-05 Thread Alex Sidorenko
On March 3, 2007 06:40:12 pm John Heffner wrote: > David Miller wrote: > > From: John Heffner <[EMAIL PROTECTED]> > > Date: Fri, 02 Mar 2007 16:16:39 -0500 > > > >> Please don't apply the patch I sent. I've been thinking about this a > >> bit harder, and it may not fix this particular problem. (H

Re: SWS for rcvbuf < MTU

2007-03-03 Thread John Heffner
David Miller wrote: From: John Heffner <[EMAIL PROTECTED]> Date: Fri, 02 Mar 2007 16:16:39 -0500 Please don't apply the patch I sent. I've been thinking about this a bit harder, and it may not fix this particular problem. (Hard to say without knowing exactly what it is.) As the comment abov

Re: SWS for rcvbuf < MTU

2007-03-02 Thread David Miller
From: John Heffner <[EMAIL PROTECTED]> Date: Fri, 02 Mar 2007 16:16:39 -0500 > Please don't apply the patch I sent. I've been thinking about this a > bit harder, and it may not fix this particular problem. (Hard to say > without knowing exactly what it is.) As the comment above > __tcp_selec

Re: SWS for rcvbuf < MTU

2007-03-02 Thread John Heffner
David Miller wrote: From: Alex Sidorenko <[EMAIL PROTECTED]> Date: Fri, 2 Mar 2007 15:21:58 -0500 they told us that they use small rcvbuf to throttle bandwidth for this application. I explained it would be better to use TC for this purpose. They agreed and will probably redesign their applicat

Re: SWS for rcvbuf < MTU

2007-03-02 Thread David Miller
From: Alex Sidorenko <[EMAIL PROTECTED]> Date: Fri, 2 Mar 2007 15:21:58 -0500 > they told us that they use small rcvbuf to throttle bandwidth for this > application. I explained it would be better to use TC for this purpose. They > agreed and will probably redesign their application in the futur

Re: SWS for rcvbuf < MTU

2007-03-02 Thread Alex Sidorenko
On March 2, 2007 01:54:45 pm John Heffner wrote: > Alex Sidorenko wrote: > [snip] > > > --- net/ipv4/tcp_output.c.orig Wed May 3 20:40:43 2006 > > +++ net/ipv4/tcp_output.c Tue Jan 30 14:24:56 2007 > > @@ -641,6 +641,7 @@ > > * Note, we don't "adjust" for TIMESTAMP or SACK option bytes. >

Re: SWS for rcvbuf < MTU

2007-03-02 Thread Alex Sidorenko
On March 2, 2007 02:25:42 pm David Miller wrote: > From: Alex Sidorenko <[EMAIL PROTECTED]> > Date: Fri, 2 Mar 2007 11:28:28 -0500 > > > Customer has confirmed that this resolves the problem and decreases > > CPU usage by his custom application - even when there is no SWS. > > There is rarely ever

Re: SWS for rcvbuf < MTU

2007-03-02 Thread David Miller
From: Alex Sidorenko <[EMAIL PROTECTED]> Date: Fri, 2 Mar 2007 11:28:28 -0500 > Customer has confirmed that this resolves the problem and decreases > CPU usage by his custom application - even when there is no SWS. There is rarely ever a reason to set explicit socket receive buffer sizes, since t

Re: SWS for rcvbuf < MTU

2007-03-02 Thread John Heffner
Alex Sidorenko wrote: [snip] --- net/ipv4/tcp_output.c.orig Wed May 3 20:40:43 2006 +++ net/ipv4/tcp_output.c Tue Jan 30 14:24:56 2007 @@ -641,6 +641,7 @@ * Note, we don't "adjust" for TIMESTAMP or SACK option bytes. * Regular options like TIMESTAMP are taken into account. */ +stati

SWS for rcvbuf < MTU

2007-03-02 Thread Alex Sidorenko
Hello, this is a rare corner case met by one of HP partners on 2.4.20 on IA64. Inspecting the sources of the latest 2.6.20.1 (net/ipv4/tcp_output.c) we can see that the bug is still there. Here is a description of the bug and the suggested fix. The problem occurs when the remote host (not nece