Re: Request to postpone WE-21

2006-10-10 Thread Jean Tourrilhes
On Tue, Oct 10, 2006 at 03:40:04PM -0400, John W. Linville wrote: > > I think this patch still has two problems. One is that the length > modification does not happen until after the "Check what user space > is giving us" clause. So, max length requests will fail. (Did you > check SIOCGIWESSID

Re: Request to postpone WE-21

2006-10-10 Thread John W. Linville
On Thu, Oct 05, 2006 at 03:12:46PM -0700, Jean Tourrilhes wrote: > On Thu, Oct 05, 2006 at 04:49:54PM -0400, John W. Linville wrote: > > On Thu, Oct 05, 2006 at 09:31:13AM -0700, Jean Tourrilhes wrote: > > > > > Based on the feedback, I formally request you to back out all > > > of WE-21 from 2.

Re: Request to postpone WE-21

2006-10-05 Thread Jeff Garzik
Jouni Malinen wrote: This looks somewhat confusing.. WE-20 (and older) included '\0' in both the data value and length (well, at least in most drivers and user space tools, if I remember correctly), i.e., essid[iwr->u.data.length] would be pointing one byte after the '\0' termination.. And since

Re: Request to postpone WE-21

2006-10-05 Thread Jean Tourrilhes
On Thu, Oct 05, 2006 at 03:15:50PM -0700, Jouni Malinen wrote: > On Thu, Oct 05, 2006 at 03:12:46PM -0700, Jean Tourrilhes wrote: > > + if((cmd == SIOCSIWESSID) || > > + (cmd == SIOCSIWNICKN)) { > > + if(extra[iwr->u.data.length - 1]

Re: Request to postpone WE-21

2006-10-05 Thread Jean Tourrilhes
On Thu, Oct 05, 2006 at 04:49:54PM -0400, John W. Linville wrote: > On Thu, Oct 05, 2006 at 09:31:13AM -0700, Jean Tourrilhes wrote: > > > Based on the feedback, I formally request you to back out all > > of WE-21 from 2.6.19. Rationale : it's probably too early. You can > > keep it for a late

Re: Request to postpone WE-21

2006-10-05 Thread Jouni Malinen
On Thu, Oct 05, 2006 at 03:12:46PM -0700, Jean Tourrilhes wrote: > + if((cmd == SIOCSIWESSID) || > +(cmd == SIOCSIWNICKN)) { > + if(extra[iwr->u.data.length - 1] == '\0') { Can't iwr->u.data.length be zero here (with WE-21)? M

Re: Request to postpone WE-21

2006-10-05 Thread Jouni Malinen
On Thu, Oct 05, 2006 at 04:49:54PM -0400, John W. Linville wrote: > What about a patch like the one below? It tries to detect WE-20 > ESSID/NICKN accesses and adjust them to WE-21 style. What am > I missing? > diff --git a/net/core/wireless.c b/net/core/wireless.c > + else

Re: Request to postpone WE-21

2006-10-05 Thread Jean Tourrilhes
On Thu, Oct 05, 2006 at 02:57:51PM -0700, Jouni Malinen wrote: > On Thu, Oct 05, 2006 at 04:49:54PM -0400, John W. Linville wrote: > > > What about a patch like the one below? It tries to detect WE-20 > > ESSID/NICKN accesses and adjust them to WE-21 style. What am > > I missing? > > > diff --g

Re: Request to postpone WE-21

2006-10-05 Thread Jean Tourrilhes
On Thu, Oct 05, 2006 at 04:49:54PM -0400, John W. Linville wrote: > On Thu, Oct 05, 2006 at 09:31:13AM -0700, Jean Tourrilhes wrote: > > > Based on the feedback, I formally request you to back out all > > of WE-21 from 2.6.19. Rationale : it's probably too early. You can > > keep it for a late

Re: Request to postpone WE-21

2006-10-05 Thread John W. Linville
On Thu, Oct 05, 2006 at 09:31:13AM -0700, Jean Tourrilhes wrote: > Based on the feedback, I formally request you to back out all > of WE-21 from 2.6.19. Rationale : it's probably too early. You can > keep it for a later date if you wish. Jean, What about a patch like the one below? It tri

Request to postpone WE-21

2006-10-05 Thread Jean Tourrilhes
Hi John, Based on the feedback, I formally request you to back out all of WE-21 from 2.6.19. Rationale : it's probably too early. You can keep it for a later date if you wish. Regards, Jean - To unsubscribe from this list: send the line "unsubscribe netdev" in the