On Thu, Dec 1, 2016 at 7:36 PM, Eric Dumazet wrote:
> On Thu, 2016-12-01 at 08:08 -0800, Eric Dumazet wrote:
>> On Thu, 2016-12-01 at 07:55 -0800, Eric Dumazet wrote:
>>
>> > So removing the spinlock is doable, but needs to add a new parameter
>> > to mlx4_en_fold_software_stats() and call netdev_
On Thu, Dec 1, 2016 at 7:08 PM, Eric Dumazet wrote:
> On Thu, 2016-12-01 at 18:33 +0200, Saeed Mahameed wrote:
>
>> Thanks for the detailed answer !!
>
> You're welcome.
>
>>
>> BTW you went 5 steps ahead of my original question :)), so far you
>> already have a patch without locking at all (reall
On Thu, 2016-12-01 at 08:08 -0800, Eric Dumazet wrote:
> On Thu, 2016-12-01 at 07:55 -0800, Eric Dumazet wrote:
>
> > So removing the spinlock is doable, but needs to add a new parameter
> > to mlx4_en_fold_software_stats() and call netdev_stats_to_stats64()
> > before mlx4_en_fold_software_stats(
On Thu, 2016-12-01 at 18:33 +0200, Saeed Mahameed wrote:
> Thanks for the detailed answer !!
You're welcome.
>
> BTW you went 5 steps ahead of my original question :)), so far you
> already have a patch without locking at all (really impressive).
>
> What i wanted to ask originally, was regard
On Thu, Dec 1, 2016 at 5:55 PM, Eric Dumazet wrote:
> On Thu, 2016-12-01 at 17:38 +0200, Saeed Mahameed wrote:
>
>>
>> Hi Eric, Thanks for the patch, I already acked it.
>
> Thanks !
>
>>
>> I have one educational question (not related to this patch, but
>> related to stats reading in general).
>>
On Thu, 2016-12-01 at 07:55 -0800, Eric Dumazet wrote:
> So removing the spinlock is doable, but needs to add a new parameter
> to mlx4_en_fold_software_stats() and call netdev_stats_to_stats64()
> before mlx4_en_fold_software_stats(dev)
Untested patch would be :
drivers/net/ethernet/mellanox/m
On Thu, 2016-12-01 at 17:38 +0200, Saeed Mahameed wrote:
>
> Hi Eric, Thanks for the patch, I already acked it.
Thanks !
>
> I have one educational question (not related to this patch, but
> related to stats reading in general).
> I was wondering why do we need to disable bh every time we read
On Wed, Nov 30, 2016 at 11:00 PM, Eric Dumazet wrote:
> On Wed, 2016-11-30 at 22:42 +0200, Saeed Mahameed wrote:
>> On Wed, Nov 30, 2016 at 7:35 PM, Eric Dumazet wrote:
>> > On Wed, 2016-11-30 at 18:46 +0200, Saeed Mahameed wrote:
>> >
>> >> we had/still have the proper stats they are the ones th
On Wed, 30 Nov 2016 13:00:52 -0800 Eric Dumazet wrote:
> On Wed, 2016-11-30 at 22:42 +0200, Saeed Mahameed wrote:
> > On Wed, Nov 30, 2016 at 7:35 PM, Eric Dumazet
> > wrote:
> > > On Wed, 2016-11-30 at 18:46 +0200, Saeed Mahameed wrote:
[...]
> > >
> > > I am suggesting I will fix the bug I
On Wed, 2016-11-30 at 22:42 +0200, Saeed Mahameed wrote:
> On Wed, Nov 30, 2016 at 7:35 PM, Eric Dumazet wrote:
> > On Wed, 2016-11-30 at 18:46 +0200, Saeed Mahameed wrote:
> >
> >> we had/still have the proper stats they are the ones that
> >> mlx4_en_fold_software_stats is trying to cache into
On Wed, Nov 30, 2016 at 7:35 PM, Eric Dumazet wrote:
> On Wed, 2016-11-30 at 18:46 +0200, Saeed Mahameed wrote:
>
>> we had/still have the proper stats they are the ones that
>> mlx4_en_fold_software_stats is trying to cache into (they always
>> exist),
>> but the ones that you are trying to read
On Wed, 2016-11-30 at 18:46 +0200, Saeed Mahameed wrote:
> we had/still have the proper stats they are the ones that
> mlx4_en_fold_software_stats is trying to cache into (they always
> exist),
> but the ones that you are trying to read from (the mlx4 rings) are gone !
>
> This bug is totally ne
On Wed, Nov 30, 2016 at 5:58 PM, Eric Dumazet wrote:
> On Wed, 2016-11-30 at 15:08 +0100, Jesper Dangaard Brouer wrote:
>> On Fri, 25 Nov 2016 07:46:20 -0800 Eric Dumazet
>> wrote:
>>
>> > From: Eric Dumazet
>>
>> Ended up-in net-next as:
>>
>> commit 40931b85113dad7881d49e8759e5ad41d30a5e6c
>
On Wed, 2016-11-30 at 15:08 +0100, Jesper Dangaard Brouer wrote:
> On Fri, 25 Nov 2016 07:46:20 -0800 Eric Dumazet
> wrote:
>
> > From: Eric Dumazet
>
> Ended up-in net-next as:
>
> commit 40931b85113dad7881d49e8759e5ad41d30a5e6c
> Author: Eric Dumazet
> Date: Fri Nov 25 07:46:20 2016 -
On Fri, 25 Nov 2016 07:46:20 -0800 Eric Dumazet wrote:
> From: Eric Dumazet
Ended up-in net-next as:
commit 40931b85113dad7881d49e8759e5ad41d30a5e6c
Author: Eric Dumazet
Date: Fri Nov 25 07:46:20 2016 -0800
mlx4: give precise rx/tx bytes/packets counters
mlx4 stats are cha
15 matches
Mail list logo
