Re: Reducing size of tc_index

2005-07-23 Thread Patrick McHardy
Jamal Hadi Salim wrote: On Sat, 2005-23-07 at 06:53 +0200, Patrick McHardy wrote: Great, thanks. Patch coming up in a couple of minutes :) The only thing i would worry about is that at some point we had assumptions about tc_index being 32 bit. I think it may have been used to carry class majo

Re: Reducing size of tc_index

2005-07-23 Thread Jamal Hadi Salim
On Sat, 2005-23-07 at 06:53 +0200, Patrick McHardy wrote: > Thomas Graf wrote: > > * Patrick McHardy <[EMAIL PROTECTED]> 2005-07-23 06:39 > > > >>I'm trying to convert tc_index to a u16, which looks OK in all places > >>but sched_gred. I can't make sense of this code: > >> > >>/* fix tc_i

Re: Reducing size of tc_index

2005-07-22 Thread Patrick McHardy
Thomas Graf wrote: * Patrick McHardy <[EMAIL PROTECTED]> 2005-07-23 06:39 I'm trying to convert tc_index to a u16, which looks OK in all places but sched_gred. I can't make sense of this code: /* fix tc_index? --could be controvesial but needed for requeueing */ skb->tc

Re: Reducing size of tc_index

2005-07-22 Thread Thomas Graf
* Patrick McHardy <[EMAIL PROTECTED]> 2005-07-23 06:39 > I'm trying to convert tc_index to a u16, which looks OK in all places > but sched_gred. I can't make sense of this code: > > /* fix tc_index? --could be controvesial but needed for >requeueing */ > skb->tc_index=(

Reducing size of tc_index

2005-07-22 Thread Patrick McHardy
Hi Jamal, I'm trying to convert tc_index to a u16, which looks OK in all places but sched_gred. I can't make sense of this code: /* fix tc_index? --could be controvesial but needed for requeueing */ skb->tc_index=(skb->tc_index&0xfff0) | t->def; Why is a mask of 0