Re: net: tso: add UDP segmentation support: adds regression for ax200 upload

2021-01-25 Thread Johannes Berg
Hi Eric, On Tue, 2021-01-19 at 11:02 +0100, Eric Dumazet wrote: > > > This does fix the problems reported on iwlwifi, were you planning to > > submit it as a proper patch? > > Sure, I will do, thanks ! Did you do that and I missed it? Or would you prefer we did? Thanks, Johannes

Re: net: tso: add UDP segmentation support: adds regression for ax200 upload

2021-01-19 Thread Johannes Berg
Hi Eric, all, Sorry we've been so silent on this. > --- a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c > +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c > @@ -773,6 +773,7 @@ iwl_mvm_tx_tso_segment(struct sk_buff *skb, > unsigned int num_subframes, > > next = skb_gso_segment(skb, netdev

Re: net: tso: add UDP segmentation support: adds regression for ax200 upload

2020-12-24 Thread Ben Greear
On 12/21/20 12:01 PM, Rainer Suhm wrote: Am 21.12.20 um 20:14 schrieb Eric Dumazet: On Mon, Dec 21, 2020 at 8:04 PM Eric Dumazet wrote: On Mon, Dec 21, 2020 at 7:46 PM Eric Dumazet wrote: On Sat, Dec 19, 2020 at 5:55 PM Ben Greear wrote: On 12/19/20 7:18 AM, Johannes Berg wrote: On Fri

Re: net: tso: add UDP segmentation support: adds regression for ax200 upload

2020-12-21 Thread Jakub Kicinski
On Mon, 21 Dec 2020 19:46:23 +0100 Eric Dumazet wrote: > So maybe the issue is coming from traffic coming from a VM through a > tun device or something, > and our handling of GSO_ROBUST / DODGY never cared about setting > SKB_GSO_TCPV4 or SKB_GSO_TCPV6 if not already given by user space ? > > Or a

Re: net: tso: add UDP segmentation support: adds regression for ax200 upload

2020-12-19 Thread Ben Greear
On 12/19/20 7:18 AM, Johannes Berg wrote: On Fri, 2020-12-18 at 12:16 -0800, Jakub Kicinski wrote: On Thu, 17 Dec 2020 12:40:26 -0800 Ben Greear wrote: On 12/17/20 10:20 AM, Eric Dumazet wrote: On Thu, Dec 17, 2020 at 7:13 PM Ben Greear wrote: It is the iwlwifi/mvm logic that supports ax200.

Re: net: tso: add UDP segmentation support: adds regression for ax200 upload

2020-12-19 Thread Johannes Berg
On Fri, 2020-12-18 at 12:16 -0800, Jakub Kicinski wrote: > On Thu, 17 Dec 2020 12:40:26 -0800 Ben Greear wrote: > > On 12/17/20 10:20 AM, Eric Dumazet wrote: > > > On Thu, Dec 17, 2020 at 7:13 PM Ben Greear > > > wrote: > > > > It is the iwlwifi/mvm logic that supports ax200. > > > > > > Let

Re: net: tso: add UDP segmentation support: adds regression for ax200 upload

2020-12-18 Thread Jakub Kicinski
On Thu, 17 Dec 2020 12:40:26 -0800 Ben Greear wrote: > On 12/17/20 10:20 AM, Eric Dumazet wrote: > > On Thu, Dec 17, 2020 at 7:13 PM Ben Greear wrote: > > > >> It is the iwlwifi/mvm logic that supports ax200. > > > > Let me ask again : > > > > I see two different potential call points : > >

Re: net: tso: add UDP segmentation support: adds regression for ax200 upload

2020-12-17 Thread Ben Greear
On 12/17/20 10:20 AM, Eric Dumazet wrote: On Thu, Dec 17, 2020 at 7:13 PM Ben Greear wrote: It is the iwlwifi/mvm logic that supports ax200. Let me ask again : I see two different potential call points : drivers/net/wireless/intel/iwlwifi/pcie/tx.c:1529: tso_build_hdr(skb, hdr_page->po

Re: net: tso: add UDP segmentation support: adds regression for ax200 upload

2020-12-17 Thread Ben Greear
On 12/17/2020 10:07 AM, Eric Dumazet wrote: On Thu, Dec 17, 2020 at 6:56 PM Ben Greear wrote: On 12/17/20 2:11 AM, Eric Dumazet wrote: On Thu, Dec 17, 2020 at 12:59 AM Ben Greear wrote: On 12/16/20 3:09 PM, Ben Greear wrote: Hello Eric, The patch below evidently causes TCP throughput to

Re: net: tso: add UDP segmentation support: adds regression for ax200 upload

2020-12-17 Thread Ben Greear
On 12/17/20 2:11 AM, Eric Dumazet wrote: On Thu, Dec 17, 2020 at 12:59 AM Ben Greear wrote: On 12/16/20 3:09 PM, Ben Greear wrote: Hello Eric, The patch below evidently causes TCP throughput to be about 50Mbps instead of 700Mbps when using ax200 to upload tcp traffic. When I disable TSO, p

Re: net: tso: add UDP segmentation support: adds regression for ax200 upload

2020-12-16 Thread Ben Greear
On 12/16/20 3:09 PM, Ben Greear wrote: Hello Eric, The patch below evidently causes TCP throughput to be about 50Mbps instead of 700Mbps when using ax200 to upload tcp traffic. When I disable TSO, performance goes back up to around 700Mbps. As a followup, when I revert the patch, upload spee