Re:Re: Re: Re:Re: Re: [PATCH net] ppp: Fix a scheduling-while-atomic bug in del_chan

2017-08-09 Thread Gao Feng
At 2017-08-10 02:18:44, "Cong Wang" wrote: >On Tue, Aug 8, 2017 at 10:13 PM, Gao Feng wrote: >> Maybe I didn't show my explanation clearly. >> I think it won't happen as I mentioned in the last email. >> Because the pptp_release invokes the synchronize_rcu to make sure it, and >> actually there

Re: Re: Re:Re: Re: [PATCH net] ppp: Fix a scheduling-while-atomic bug in del_chan

2017-08-09 Thread Cong Wang
On Tue, Aug 8, 2017 at 10:13 PM, Gao Feng wrote: > Maybe I didn't show my explanation clearly. > I think it won't happen as I mentioned in the last email. > Because the pptp_release invokes the synchronize_rcu to make sure it, and > actually there is no one which would invoke del_chan except pptp

Re: Re:Re: Re: [PATCH net] ppp: Fix a scheduling-while-atomic bug in del_chan

2017-08-08 Thread Cong Wang
On Mon, Aug 7, 2017 at 6:10 PM, Gao Feng wrote: > > Sorry, I don't get you clearly. Why the sock_hold() isn't helpful? I already told you, the dereference happends before sock_hold(). sock = rcu_dereference(callid_sock[call_id]); if (sock) { opt = &sock->proto.ppt