Re: [RFC PATCH net-next] net: dsa: mt7530: rename MT7621 compatible

2020-12-20 Thread Chuanhong Guo
Hi! On Sun, Dec 20, 2020 at 1:10 AM Florian Fainelli wrote: > > > > On 12/19/2020 8:26 AM, Andrew Lunn wrote: > >> --- a/drivers/net/dsa/mt7530.c > >> +++ b/drivers/net/dsa/mt7530.c > >> @@ -2688,7 +2688,7 @@ static const struct mt753x_info mt753x_table[] = { > >> }; > >> > >> static const stru

Re: [RFC PATCH net-next] net: dsa: mt7530: rename MT7621 compatible

2020-12-20 Thread Vladimir Oltean
On Sun, Dec 20, 2020 at 12:21:53AM +0800, DENG Qingfang wrote: > MT7621 is a SoC, so using "mediatek,mt7621" as its compatible is ambiguous. > Rename it to "mediatek,mt7621-gsw". > > Signed-off-by: DENG Qingfang > --- I would say that you need to resolve the situation with the docs at Documentat

Re: [RFC PATCH net-next] net: dsa: mt7530: rename MT7621 compatible

2020-12-20 Thread Vladimir Oltean
On Sun, Dec 20, 2020 at 04:36:27PM +0800, DENG Qingfang wrote: > On Sun, Dec 20, 2020 at 3:49 PM Vladimir Oltean wrote: > > But still, what is at memory address 0x1e11, if the switch is > > accessed over MDIO? > > It's "Ethernet GMAC", handled by mtk_eth_soc. I see. You have some work to do w

Re: [RFC PATCH net-next] net: dsa: mt7530: rename MT7621 compatible

2020-12-20 Thread DENG Qingfang
On Sun, Dec 20, 2020 at 3:49 PM Vladimir Oltean wrote: > But still, what is at memory address 0x1e11, if the switch is > accessed over MDIO? It's "Ethernet GMAC", handled by mtk_eth_soc.

Re: [RFC PATCH net-next] net: dsa: mt7530: rename MT7621 compatible

2020-12-19 Thread Vladimir Oltean
On Sun, Dec 20, 2020 at 12:48:08PM +0800, DENG Qingfang wrote: > Hi Vladimir, > > On Sun, Dec 20, 2020 at 3:48 AM Vladimir Oltean wrote: > > > > Hi Andrew, Florian, > > > > On Sat, Dec 19, 2020 at 09:07:13AM -0800, Florian Fainelli wrote: > > > On 12/19/2020 8:26 AM, Andrew Lunn wrote: > > > >> -

Re: [RFC PATCH net-next] net: dsa: mt7530: rename MT7621 compatible

2020-12-19 Thread DENG Qingfang
Hi Vladimir, On Sun, Dec 20, 2020 at 3:48 AM Vladimir Oltean wrote: > > Hi Andrew, Florian, > > On Sat, Dec 19, 2020 at 09:07:13AM -0800, Florian Fainelli wrote: > > On 12/19/2020 8:26 AM, Andrew Lunn wrote: > > >> --- a/drivers/net/dsa/mt7530.c > > >> +++ b/drivers/net/dsa/mt7530.c > > >> @@ -26

Re: [RFC PATCH net-next] net: dsa: mt7530: rename MT7621 compatible

2020-12-19 Thread Vladimir Oltean
Hi Andrew, Florian, On Sat, Dec 19, 2020 at 09:07:13AM -0800, Florian Fainelli wrote: > On 12/19/2020 8:26 AM, Andrew Lunn wrote: > >> --- a/drivers/net/dsa/mt7530.c > >> +++ b/drivers/net/dsa/mt7530.c > >> @@ -2688,7 +2688,7 @@ static const struct mt753x_info mt753x_table[] = { > >> }; > >> >

Re: [RFC PATCH net-next] net: dsa: mt7530: rename MT7621 compatible

2020-12-19 Thread Florian Fainelli
On 12/19/2020 8:26 AM, Andrew Lunn wrote: >> --- a/drivers/net/dsa/mt7530.c >> +++ b/drivers/net/dsa/mt7530.c >> @@ -2688,7 +2688,7 @@ static const struct mt753x_info mt753x_table[] = { >> }; >> >> static const struct of_device_id mt7530_of_match[] = { >> -{ .compatible = "mediatek,mt762

Re: [RFC PATCH net-next] net: dsa: mt7530: rename MT7621 compatible

2020-12-19 Thread Andrew Lunn
> --- a/drivers/net/dsa/mt7530.c > +++ b/drivers/net/dsa/mt7530.c > @@ -2688,7 +2688,7 @@ static const struct mt753x_info mt753x_table[] = { > }; > > static const struct of_device_id mt7530_of_match[] = { > - { .compatible = "mediatek,mt7621", .data = &mt753x_table[ID_MT7621], }, > + {