Hi Maciej Fijalkowski,
[...]
> > + tx_ctrl.cksum_offload_flag = false;
> > + tx_ctrl.tcp_seg_offload_flag = false;
> > + tx_ctrl.tcp_seg_len = 0;
>
> Aren't these three lines redundant? tx_ctrl is zero initialized.
>
Yea i think i can remove those
> > +
> > + tx_desc.dma_addr = dma_hand
On Tue, 25 Jun 2019 18:06:19 +0300
Ilias Apalodimas wrote:
Hi Ilias,
> +/* The current driver only supports 1 Txq, this should run under spin_lock()
> */
> +static u32 netsec_xdp_queue_one(struct netsec_priv *priv,
> + struct xdp_frame *xdpf, bool is_ndo)
> +
> +{
>
On Thu, Jun 27, 2019 at 02:23:05PM +0200, Jesper Dangaard Brouer wrote:
> On Tue, 25 Jun 2019 18:06:19 +0300
> Ilias Apalodimas wrote:
>
> > @@ -609,6 +639,9 @@ static bool netsec_clean_tx_dring(struct netsec_priv
> > *priv)
> > int tail = dring->tail;
> > int cnt = 0;
> >
> > + if (
On Tue, 25 Jun 2019 18:06:19 +0300
Ilias Apalodimas wrote:
> @@ -609,6 +639,9 @@ static bool netsec_clean_tx_dring(struct netsec_priv
> *priv)
> int tail = dring->tail;
> int cnt = 0;
>
> + if (dring->is_xdp)
> + spin_lock(&dring->lock);
> +
> pkts = 0;
>
