Re: Re: [PATCH v3 2/2] drivers: net: ethernet: 3com: fix return value

2016-12-29 Thread Thomas Preisner
On Tue, 2016-12-27 at 22:17:35 +0100, David Dillow wrote: >On Sun, 2016-12-25 at 01:30 +0100, Thomas Preisner wrote: >> In some cases the return value of a failing function is not being used >> and the function typhoon_init_one() returns another negative error >> code instead. > >I'm not sure these

Re: [PATCH v3 2/2] drivers: net: ethernet: 3com: fix return value

2016-12-27 Thread David Dillow
On Sun, 2016-12-25 at 01:30 +0100, Thomas Preisner wrote: > In some cases the return value of a failing function is not being used > and the function typhoon_init_one() returns another negative error > code instead. I'm not sure these changes are especially valuable, since we'll need to look at th

Re: [PATCH v3 2/2] drivers: net: ethernet: 3com: fix return value

2016-12-25 Thread Sergei Shtylyov
Hello! On 12/25/2016 3:30 AM, Thomas Preisner wrote: In some cases the return value of a failing function is not being used and the function typhoon_init_one() returns another negative error code instead. Signed-off-by: Thomas Preisner Signed-off-by: Milan Stephan --- drivers/net/ethernet/3