Re: [PATCH v3 1/1] xdp: remove the function xsk_map_inc

2020-11-26 Thread Zhu Yanjun
On Wed, Nov 25, 2020 at 4:33 PM Magnus Karlsson wrote: > > On Wed, Nov 25, 2020 at 1:02 AM Daniel Borkmann wrote: > > > > On 11/23/20 4:05 PM, Zhu Yanjun wrote: > > > From: Zhu Yanjun > > > > > > The function xsk_map_inc is a simple wrapper of bpf_map_inc and > > > always returns zero. As such,

Re: [PATCH v3 1/1] xdp: remove the function xsk_map_inc

2020-11-25 Thread Magnus Karlsson
On Wed, Nov 25, 2020 at 1:02 AM Daniel Borkmann wrote: > > On 11/23/20 4:05 PM, Zhu Yanjun wrote: > > From: Zhu Yanjun > > > > The function xsk_map_inc is a simple wrapper of bpf_map_inc and > > always returns zero. As such, replacing this function with bpf_map_inc > > and removing the test code.

Re: [PATCH v3 1/1] xdp: remove the function xsk_map_inc

2020-11-24 Thread Daniel Borkmann
On 11/23/20 4:05 PM, Zhu Yanjun wrote: From: Zhu Yanjun The function xsk_map_inc is a simple wrapper of bpf_map_inc and always returns zero. As such, replacing this function with bpf_map_inc and removing the test code. Signed-off-by: Zhu Yanjun --- net/xdp/xsk.c| 2 +- net/xdp/xsk.h

Re: [PATCH v3 1/1] xdp: remove the function xsk_map_inc

2020-11-24 Thread Magnus Karlsson
On Mon, Nov 23, 2020 at 4:07 PM Zhu Yanjun wrote: > > From: Zhu Yanjun > > The function xsk_map_inc is a simple wrapper of bpf_map_inc and > always returns zero. As such, replacing this function with bpf_map_inc > and removing the test code. Applied it to bpf-next, compiled it and tested it and

Re: [PATCH v3 1/1] xdp: remove the function xsk_map_inc

2020-11-23 Thread Magnus Karlsson
On Mon, Nov 23, 2020 at 3:30 PM Zhu Yanjun wrote: > > On Mon, Nov 23, 2020 at 10:27 PM wrote: > > > > From: Zhu Yanjun > > > > The function xsk_map_inc is a simple wrapper of bpf_map_inc and > > always returns zero. As such, replacing this function with bpf_map_inc > > and removing the test code

Re: [PATCH v3 1/1] xdp: remove the function xsk_map_inc

2020-11-23 Thread Zhu Yanjun
On Mon, Nov 23, 2020 at 10:27 PM wrote: > > From: Zhu Yanjun > > The function xsk_map_inc is a simple wrapper of bpf_map_inc and > always returns zero. As such, replacing this function with bpf_map_inc > and removing the test code. > > Signed-off-by: Zhu Yanjun > --- > net/xdp/xsk.c| 2 +-