Re: [PATCH v3] net: dsa: qca8k: enable port flow control

2019-07-30 Thread David Miller
From: xiaofeis Date: Sun, 28 Jul 2019 08:57:50 +0800 > Set phy device advertising to enable MAC flow control. > > Signed-off-by: Xiaofei Shen I've read the discussion over a few times and if internal PHY is the only thing supported, and the specific setup this driver supports uses internal sig

Re: [PATCH v3] net: dsa: qca8k: enable port flow control

2019-07-29 Thread xiaofeis
On 2019-07-29 21:23, Andrew Lunn wrote: But our qca8k HW can auto sync the pause status to MAC from phy with the auto-negotiated result. So no need to set in qca8k_adjust_link, since there is one setting in qca8k_port_set_status: mask |= QCA8K_PORT_STATUS_LINK_AUTO; How does the auto-sync actu

Re: [PATCH v3] net: dsa: qca8k: enable port flow control

2019-07-29 Thread Andrew Lunn
> But our qca8k HW can auto sync the pause status to MAC from phy with the > auto-negotiated result. > So no need to set in qca8k_adjust_link, since there is one setting in > qca8k_port_set_status: mask |= QCA8K_PORT_STATUS_LINK_AUTO; How does the auto-sync actually work? Does the MAC make MDIO re

Re: [PATCH v3] net: dsa: qca8k: enable port flow control

2019-07-28 Thread xiaofeis
On 2019-07-29 06:31, Andrew Lunn wrote: On Sun, Jul 28, 2019 at 08:57:50AM +0800, xiaofeis wrote: Set phy device advertising to enable MAC flow control. Hi Xiaofei. This is half of the needed change for MAC flow control. phy_support_asym_pause(phy) is used by the MAC to tell the PHY layer th

Re: [PATCH v3] net: dsa: qca8k: enable port flow control

2019-07-28 Thread Andrew Lunn
On Sun, Jul 28, 2019 at 08:57:50AM +0800, xiaofeis wrote: > Set phy device advertising to enable MAC flow control. Hi Xiaofei. This is half of the needed change for MAC flow control. phy_support_asym_pause(phy) is used by the MAC to tell the PHY layer that the MAC supports flow control. The PHY