A spi core fix has been accepted which makes this patch unnecessary.
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/commit/?id=766c6b63aa044e84b045803b40b14754d69a2a1d
On Tue, Nov 10, 2020 at 9:20 AM Sven Van Asbroeck wrote:
>
>
> This driver makes sure the underlying SPI bus is
On Tue, Nov 10, 2020 at 12:06:37PM -0500, Sven Van Asbroeck wrote:
> PING Jakub
>
> On Tue, Nov 10, 2020 at 11:30 AM Andy Shevchenko
> wrote:
> >
> > I see that this is a fix for backporing, but maybe you can send a
> > patches on top of this to:
> > 1) introduce
> > #define SPI_MODE_MASK (SP
PING Jakub
On Tue, Nov 10, 2020 at 11:30 AM Andy Shevchenko
wrote:
>
> I see that this is a fix for backporing, but maybe you can send a
> patches on top of this to:
> 1) introduce
> #define SPI_MODE_MASK (SPI_CPHA | SPI_CPOL)
>spi->mode &= ~SPI_MODE_MASK;
> > + spi->mode |= SPI
Hi Andy, thank you for the feedback.
On Tue, Nov 10, 2020 at 11:30 AM Andy Shevchenko
wrote:
>
> I see that this is a fix for backporing, but maybe you can send a
> patches on top of this to:
> 1) introduce
> #define SPI_MODE_MASK (SPI_CPHA | SPI_CPOL)
>spi->mode &= ~SPI_MODE_MASK;
>
On Tue, Nov 10, 2020 at 4:20 PM Sven Van Asbroeck wrote:
>
> From: Sven Van Asbroeck
>
> This driver makes sure the underlying SPI bus is set to "mode 0"
> by assigning SPI_MODE_0 to spi->mode. Which overwrites all other
> SPI mode flags.
>
> In some circumstances, this can break the underlying S
