Re: [PATCH net-next v2 1/3] dsa: add support for Arrow XRS700x tag trailer

2020-11-26 Thread Vladimir Oltean
On Thu, Nov 26, 2020 at 03:01:26PM +0100, Andrew Lunn wrote: > On Thu, Nov 26, 2020 at 03:50:04PM +0200, Vladimir Oltean wrote: > > On Wed, Nov 25, 2020 at 09:34:29PM +0100, Andrew Lunn wrote: > > > > +static struct sk_buff *xrs700x_rcv(struct sk_buff *skb, struct > > > > net_device *dev, > > > >

Re: [PATCH net-next v2 1/3] dsa: add support for Arrow XRS700x tag trailer

2020-11-26 Thread Andrew Lunn
On Thu, Nov 26, 2020 at 03:50:04PM +0200, Vladimir Oltean wrote: > On Wed, Nov 25, 2020 at 09:34:29PM +0100, Andrew Lunn wrote: > > > +static struct sk_buff *xrs700x_rcv(struct sk_buff *skb, struct > > > net_device *dev, > > > +struct packet_type *pt) > > > +{ > > > + i

Re: [PATCH net-next v2 1/3] dsa: add support for Arrow XRS700x tag trailer

2020-11-26 Thread Vladimir Oltean
On Wed, Nov 25, 2020 at 09:34:29PM +0100, Andrew Lunn wrote: > > +static struct sk_buff *xrs700x_rcv(struct sk_buff *skb, struct net_device > > *dev, > > + struct packet_type *pt) > > +{ > > + int source_port; > > + u8 *trailer; > > + > > + if (skb_linearize(skb)

Re: [PATCH net-next v2 1/3] dsa: add support for Arrow XRS700x tag trailer

2020-11-25 Thread Florian Fainelli
On 11/25/2020 11:37 AM, George McCollister wrote: > Add support for Arrow SpeedChips XRS700x single byte tag trailer. This > is modeled on tag_trailer.c which works in a similar way. > > Signed-off-by: George McCollister Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next v2 1/3] dsa: add support for Arrow XRS700x tag trailer

2020-11-25 Thread Andrew Lunn
On Wed, Nov 25, 2020 at 01:37:38PM -0600, George McCollister wrote: > Add support for Arrow SpeedChips XRS700x single byte tag trailer. This > is modeled on tag_trailer.c which works in a similar way. > > Signed-off-by: George McCollister Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next v2 1/3] dsa: add support for Arrow XRS700x tag trailer

2020-11-25 Thread Andrew Lunn
> +static struct sk_buff *xrs700x_rcv(struct sk_buff *skb, struct net_device > *dev, > +struct packet_type *pt) > +{ > + int source_port; > + u8 *trailer; > + > + if (skb_linearize(skb)) > + return NULL; Something for Vladimir: Could this l