Re: [PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-06-07 Thread Heiner Kallweit
On 05.06.2018 21:39, Heiner Kallweit wrote: > On 02.06.2018 22:27, Heiner Kallweit wrote: >> On 01.06.2018 02:10, Andrew Lunn wrote: Configuring the different WoL options isn't handled by writing to the PHY registers but by writing to chip / MAC registers. Therefore phy_suspend() isn

Re: [PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-06-05 Thread Heiner Kallweit
On 02.06.2018 22:27, Heiner Kallweit wrote: > On 01.06.2018 02:10, Andrew Lunn wrote: >>> Configuring the different WoL options isn't handled by writing to >>> the PHY registers but by writing to chip / MAC registers. >>> Therefore phy_suspend() isn't able to figure out whether WoL is >>> enabled o

Re: [PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-06-02 Thread Heiner Kallweit
On 01.06.2018 02:10, Andrew Lunn wrote: >> Configuring the different WoL options isn't handled by writing to >> the PHY registers but by writing to chip / MAC registers. >> Therefore phy_suspend() isn't able to figure out whether WoL is >> enabled or not. Only the parent has the full picture. > >

Re: [PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-05-31 Thread Andrew Lunn
> Configuring the different WoL options isn't handled by writing to > the PHY registers but by writing to chip / MAC registers. > Therefore phy_suspend() isn't able to figure out whether WoL is > enabled or not. Only the parent has the full picture. Hi Heiner I think you need to look at your diff

Re: [PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-05-31 Thread Heiner Kallweit
On 31.05.2018 20:30, Andrew Lunn wrote: >> By the way: The problem is related to an experimental patch series for >> splitting r8169/r8168 drivers and switching r8168 to phylib. >> Therefore the change to r8168.c won't apply to existing kernel code. > > Hi Heiner > > I still think you are trying

Re: [PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-05-31 Thread Andrew Lunn
> By the way: The problem is related to an experimental patch series for > splitting r8169/r8168 drivers and switching r8168 to phylib. > Therefore the change to r8168.c won't apply to existing kernel code. Hi Heiner I still think you are trying to fix the wrong problem. Lets take a look at thes

Re: [PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-05-31 Thread Heiner Kallweit
On 30.05.2018 22:35, Andrew Lunn wrote: >> I think we need a better solution than spending the effort needed >> to make the MDIO ops runtime-pm-aware. In general there seems to be >> just one network driver using both phylib and runtime pm, so most >> drivers aren't affected (yet). >> >> I will spe

Re: [PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-05-30 Thread Andrew Lunn
> I think we need a better solution than spending the effort needed > to make the MDIO ops runtime-pm-aware. In general there seems to be > just one network driver using both phylib and runtime pm, so most > drivers aren't affected (yet). > > I will spend few more thoughts on a solution .. Hi Hei

Re: [PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-05-30 Thread Heiner Kallweit
Am 24.05.2018 um 00:04 schrieb Andrew Lunn: > On Wed, May 23, 2018 at 10:15:29PM +0200, Heiner Kallweit wrote: >> I have the issue that suspending the MAC-integrated PHY gives an >> error during system suspend. The sequence is: >> >> 1. unconnected PHY/MAC are runtime-suspended already >> 2. system

Re: [PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-05-23 Thread Heiner Kallweit
Am 24.05.2018 um 00:04 schrieb Andrew Lunn: > On Wed, May 23, 2018 at 10:15:29PM +0200, Heiner Kallweit wrote: >> I have the issue that suspending the MAC-integrated PHY gives an >> error during system suspend. The sequence is: >> >> 1. unconnected PHY/MAC are runtime-suspended already >> 2. system

Re: [PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-05-23 Thread Andrew Lunn
On Wed, May 23, 2018 at 10:15:29PM +0200, Heiner Kallweit wrote: > I have the issue that suspending the MAC-integrated PHY gives an > error during system suspend. The sequence is: > > 1. unconnected PHY/MAC are runtime-suspended already > 2. system suspend commences > 3. mdio_bus_phy_suspend is ca