Re: [PATCH net-next 2/4] veth: allow enabling NAPI even without XDP

2021-04-16 Thread Toke Høiland-Jørgensen
Paolo Abeni writes: > On Fri, 2021-04-16 at 17:29 +0200, Toke Høiland-Jørgensen wrote: >> Paolo Abeni writes: >> >> > On Fri, 2021-04-09 at 16:58 +0200, Toke Høiland-Jørgensen wrote: >> > > Paolo Abeni writes: >> > > >> > > > Currently the veth device has the GRO feature bit set, even if >> >

Re: [PATCH net-next 2/4] veth: allow enabling NAPI even without XDP

2021-04-16 Thread Paolo Abeni
On Fri, 2021-04-16 at 17:29 +0200, Toke Høiland-Jørgensen wrote: > Paolo Abeni writes: > > > On Fri, 2021-04-09 at 16:58 +0200, Toke Høiland-Jørgensen wrote: > > > Paolo Abeni writes: > > > > > > > Currently the veth device has the GRO feature bit set, even if > > > > no GRO aggregation is poss

Re: [PATCH net-next 2/4] veth: allow enabling NAPI even without XDP

2021-04-16 Thread Toke Høiland-Jørgensen
Paolo Abeni writes: > On Fri, 2021-04-09 at 16:58 +0200, Toke Høiland-Jørgensen wrote: >> Paolo Abeni writes: >> >> > Currently the veth device has the GRO feature bit set, even if >> > no GRO aggregation is possible with the default configuration, >> > as the veth device does not hook into the

Re: [PATCH net-next 2/4] veth: allow enabling NAPI even without XDP

2021-04-09 Thread Paolo Abeni
On Fri, 2021-04-09 at 16:58 +0200, Toke Høiland-Jørgensen wrote: > Paolo Abeni writes: > > > Currently the veth device has the GRO feature bit set, even if > > no GRO aggregation is possible with the default configuration, > > as the veth device does not hook into the GRO engine. > > > > Flippin

Re: [PATCH net-next 2/4] veth: allow enabling NAPI even without XDP

2021-04-09 Thread Toke Høiland-Jørgensen
Paolo Abeni writes: > Currently the veth device has the GRO feature bit set, even if > no GRO aggregation is possible with the default configuration, > as the veth device does not hook into the GRO engine. > > Flipping the GRO feature bit from user-space is a no-op, unless > XDP is enabled. In su