Re: [PATCH net-next 1/3] ipv6: fib6_info_destroy_rcu() cleanup

2019-04-23 Thread David Ahern
On 4/23/19 11:40 AM, Eric Dumazet wrote: > I believe we have a problem with f6i->rt6i_pcpu rules : > > It seems concurrent lookups can happily use it while > the call_rcu() is ongoing before fib6_info_destroy_rcu() is finally called. > > We lack proper RCU rules here. Concurrent lookups should be

Re: [PATCH net-next 1/3] ipv6: fib6_info_destroy_rcu() cleanup

2019-04-23 Thread Eric Dumazet
On Tue, Apr 23, 2019 at 9:33 AM David Ahern wrote: > > On 4/22/19 7:35 PM, Eric Dumazet wrote: > > We do not need to clear f6i->rt6i_exception_bucket right before > > freeing f6i. > > > > Note that f6i->rt6i_exception_bucket is properly protected by > > f6i->exception_bucket_flushed being set to o

Re: [PATCH net-next 1/3] ipv6: fib6_info_destroy_rcu() cleanup

2019-04-23 Thread David Ahern
On 4/22/19 7:35 PM, Eric Dumazet wrote: > We do not need to clear f6i->rt6i_exception_bucket right before > freeing f6i. > > Note that f6i->rt6i_exception_bucket is properly protected by > f6i->exception_bucket_flushed being set to one in rt6_flush_exceptions() > under the protection of rt6_except

Re: [PATCH net-next 1/3] ipv6: fib6_info_destroy_rcu() cleanup

2019-04-23 Thread Wei Wang
On Mon, Apr 22, 2019 at 6:35 PM Eric Dumazet wrote: > > We do not need to clear f6i->rt6i_exception_bucket right before > freeing f6i. > > Note that f6i->rt6i_exception_bucket is properly protected by > f6i->exception_bucket_flushed being set to one in rt6_flush_exceptions() > under the protection