Re: [PATCH net-next 0/2] Introduce XDP_FLAGS_NO_TX flag

2021-01-11 Thread Charlie Somerville
On Tue, Jan 12, 2021, at 14:03, Jason Wang wrote: > > On 2021/1/9 上午10:49, Charlie Somerville wrote: > > This patch series introduces a new flag XDP_FLAGS_NO_TX which prevents > > the allocation of additional send queues for XDP programs. > > > This part I don't understand. Is such flag a must?

Re: [PATCH net-next 0/2] Introduce XDP_FLAGS_NO_TX flag

2021-01-11 Thread Jason Wang
On 2021/1/9 上午10:49, Charlie Somerville wrote: This patch series introduces a new flag XDP_FLAGS_NO_TX which prevents the allocation of additional send queues for XDP programs. This part I don't understand. Is such flag a must? I think the answer is probably not. Why not simply do: 1) if

Re: [PATCH net-next 0/2] Introduce XDP_FLAGS_NO_TX flag

2021-01-11 Thread Toke Høiland-Jørgensen
Charlie Somerville writes: > This patch series introduces a new flag XDP_FLAGS_NO_TX which prevents > the allocation of additional send queues for XDP programs. > > Included in this patch series is an implementation of XDP_FLAGS_NO_TX > for the virtio_net driver. This flag is intended to be advis