Re: [PATCH net-next] net: DSCP in IPv4 routing v2

2020-11-24 Thread Guillaume Nault
On Tue, Nov 24, 2020 at 12:41:49PM +1000, Russell Strong wrote: > On Mon, 23 Nov 2020 23:55:05 +0100 Guillaume Nault wrote: > > On Sat, Nov 21, 2020 at 06:24:46PM +1000, Russell Strong wrote: > > I was wondering if one patch would be acceptable, or should it be broken > up? If broken up. It woul

Re: [PATCH net-next] net: DSCP in IPv4 routing v2

2020-11-23 Thread Russell Strong
On Mon, 23 Nov 2020 23:55:05 +0100 Guillaume Nault wrote: > On Sat, Nov 21, 2020 at 06:24:46PM +1000, Russell Strong wrote: > > From 2f27f92d5a6f4dd69ac4af32cdb51ba8d2083606 Mon Sep 17 00:00:00 2001 > > From: Russell Strong > > Date: Sat, 21 Nov 2020 18:12:43 +1000 > > Subject: [PATCH] DSCP in I

Re: [PATCH net-next] net: DSCP in IPv4 routing v2

2020-11-23 Thread Guillaume Nault
On Sat, Nov 21, 2020 at 06:24:46PM +1000, Russell Strong wrote: > From 2f27f92d5a6f4dd69ac4af32cdb51ba8d2083606 Mon Sep 17 00:00:00 2001 > From: Russell Strong > Date: Sat, 21 Nov 2020 18:12:43 +1000 > Subject: [PATCH] DSCP in IPv4 routing v2 > > This patch allows the use of DSCP values in routin

Re: Re: [PATCH net-next] net: DSCP in IPv4 routing

2020-11-16 Thread kernel test robot
Hi Russell, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Russell-Strong/Re-PATCH-net-next-net-DSCP-in-IPv4-routing/20201115-071518 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net

Re: [PATCH net-next] net: DSCP in IPv4 routing

2020-11-14 Thread Russell Strong
[PATCH 2/2] DSCP in IPv4 routing TOS handling in ipv4 routing does not use all the bits in a DSCP value. This change introduces a sysctl "route_tos_as_dscp" control that, when enabled, widens masks to used the 6 DSCP bits in routing. This commit converts macros RT_TOS -> rt_tos IPTOS_RT_MASK ->

Re: [PATCH net-next] net: DSCP in IPv4 routing

2020-11-14 Thread Russell Strong
[PATCH 1/2] DSCP in IPv4 routing TOS handling in ipv4 routing does not use all the bits in a DSCP value. This change introduces a sysctl "route_tos_as_dscp" control that, when enabled, widens masks to used the 6 DSCP bits in routing. This commit adds the sysctl Signed-off-by: Russell Strong --

Re: [PATCH net-next] net: DSCP in IPv4 routing

2020-11-14 Thread Russell Strong
On Fri, 13 Nov 2020 10:02:25 +0100 Guillaume Nault wrote: > On Thu, Nov 12, 2020 at 07:36:56PM -0800, Stephen Hemminger wrote: > > On Fri, 13 Nov 2020 12:06:37 +1000 > > Russell Strong wrote: > > > > > diff --git a/include/uapi/linux/in_route.h > > > b/include/uapi/linux/in_route.h index 0cc2

Re: [PATCH net-next] net: DSCP in IPv4 routing

2020-11-13 Thread Guillaume Nault
On Thu, Nov 12, 2020 at 07:36:56PM -0800, Stephen Hemminger wrote: > On Fri, 13 Nov 2020 12:06:37 +1000 > Russell Strong wrote: > > > diff --git a/include/uapi/linux/in_route.h > > b/include/uapi/linux/in_route.h index 0cc2c23b47f8..db5d236b9c50 100644 > > --- a/include/uapi/linux/in_route.h > >

Re: [PATCH net-next] net: DSCP in IPv4 routing

2020-11-12 Thread Stephen Hemminger
On Fri, 13 Nov 2020 12:06:37 +1000 Russell Strong wrote: > diff --git a/include/uapi/linux/in_route.h > b/include/uapi/linux/in_route.h index 0cc2c23b47f8..db5d236b9c50 100644 > --- a/include/uapi/linux/in_route.h > +++ b/include/uapi/linux/in_route.h > @@ -28,6 +28,6 @@ > > #define RTCF_NAT