Re: [PATCH bpf 1/3] bpf: syscall to start at file-descriptor 1

2020-06-08 Thread kernel test robot
Hi Jesper, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf/master] url: https://github.com/0day-ci/linux/commits/Jesper-Dangaard-Brouer/bpf-avoid-using-returning-file-descriptor-value-zero/20200609-005457 base: https://git.kernel.org/pub/scm/linux/kernel/gi

Re: [PATCH bpf 1/3] bpf: syscall to start at file-descriptor 1

2020-06-08 Thread kernel test robot
Hi Jesper, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf/master] url: https://github.com/0day-ci/linux/commits/Jesper-Dangaard-Brouer/bpf-avoid-using-returning-file-descriptor-value-zero/20200609-005457 base: https://git.kernel.org/pub/scm/linux/kernel/gi

Re: [PATCH bpf 1/3] bpf: syscall to start at file-descriptor 1

2020-06-08 Thread kernel test robot
Hi Jesper, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf/master] url: https://github.com/0day-ci/linux/commits/Jesper-Dangaard-Brouer/bpf-avoid-using-returning-file-descriptor-value-zero/20200609-005457 base: https://git.kernel.org/pub/scm/linux/kernel/gi

Re: [PATCH bpf 1/3] bpf: syscall to start at file-descriptor 1

2020-06-08 Thread kernel test robot
Hi Jesper, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf/master] url: https://github.com/0day-ci/linux/commits/Jesper-Dangaard-Brouer/bpf-avoid-using-returning-file-descriptor-value-zero/20200609-005457 base: https://git.kernel.org/pub/scm/linux/kernel/gi

Re: [PATCH bpf 1/3] bpf: syscall to start at file-descriptor 1

2020-06-08 Thread Andrii Nakryiko
-- Andrii On Mon, Jun 8, 2020 at 12:45 PM Jesper Dangaard Brouer wrote: > > On Mon, 8 Jun 2020 11:36:33 -0700 > Andrii Nakryiko wrote: > > > On Mon, Jun 8, 2020 at 9:51 AM Jesper Dangaard Brouer > > wrote: > > > > > > This patch change BPF syscall to avoid returning file descriptor value > >

Re: [PATCH bpf 1/3] bpf: syscall to start at file-descriptor 1

2020-06-08 Thread Jesper Dangaard Brouer
On Mon, 8 Jun 2020 11:36:33 -0700 Andrii Nakryiko wrote: > On Mon, Jun 8, 2020 at 9:51 AM Jesper Dangaard Brouer > wrote: > > > > This patch change BPF syscall to avoid returning file descriptor value zero. > > > > As mentioned in cover letter, it is very impractical when extending kABI > > tha

Re: [PATCH bpf 1/3] bpf: syscall to start at file-descriptor 1

2020-06-08 Thread Andrii Nakryiko
On Mon, Jun 8, 2020 at 9:51 AM Jesper Dangaard Brouer wrote: > > This patch change BPF syscall to avoid returning file descriptor value zero. > > As mentioned in cover letter, it is very impractical when extending kABI > that the file-descriptor value 'zero' is valid, as this requires new fields >

Re: [PATCH bpf 1/3] bpf: syscall to start at file-descriptor 1

2020-06-08 Thread Toke Høiland-Jørgensen
Jesper Dangaard Brouer writes: > This patch change BPF syscall to avoid returning file descriptor value zero. > > As mentioned in cover letter, it is very impractical when extending kABI > that the file-descriptor value 'zero' is valid, as this requires new fields > must be initialised as minus-1