Re: [PATCH bpf-next 1/6] i40e: introduce lazy Tx completions for AF_XDP zero-copy

2020-11-06 Thread Magnus Karlsson
On Thu, Nov 5, 2020 at 4:45 PM Jakub Kicinski wrote: > > On Thu, 5 Nov 2020 15:17:50 +0100 Magnus Karlsson wrote: > > > I feel like this needs a big fat warning somewhere. > > > > > > It's perfectly fine to never complete TCP packets, but AF_XDP could be > > > used to implement protocols in user s

Re: [PATCH bpf-next 1/6] i40e: introduce lazy Tx completions for AF_XDP zero-copy

2020-11-05 Thread Jakub Kicinski
On Thu, 5 Nov 2020 15:17:50 +0100 Magnus Karlsson wrote: > > I feel like this needs a big fat warning somewhere. > > > > It's perfectly fine to never complete TCP packets, but AF_XDP could be > > used to implement protocols in user space. What if someone wants to > > implement something like TSQ?

Re: [PATCH bpf-next 1/6] i40e: introduce lazy Tx completions for AF_XDP zero-copy

2020-11-05 Thread Magnus Karlsson
On Thu, Nov 5, 2020 at 12:33 AM Jakub Kicinski wrote: > > On Wed, 4 Nov 2020 15:08:57 +0100 Magnus Karlsson wrote: > > From: Magnus Karlsson > > > > Introduce lazy Tx completions when a queue is used for AF_XDP > > zero-copy. In the current design, each time we get into the NAPI poll > > loop we

Re: [PATCH bpf-next 1/6] i40e: introduce lazy Tx completions for AF_XDP zero-copy

2020-11-04 Thread Jakub Kicinski
On Wed, 4 Nov 2020 15:33:20 -0800 Jakub Kicinski wrote: > I feel like this needs a big fat warning somewhere. > > It's perfectly fine to never complete TCP packets, s/TCP/normal XDP/, sorry > but AF_XDP could be used to implement protocols in user space. What > if someone wants to implement some

Re: [PATCH bpf-next 1/6] i40e: introduce lazy Tx completions for AF_XDP zero-copy

2020-11-04 Thread Jakub Kicinski
On Wed, 4 Nov 2020 15:08:57 +0100 Magnus Karlsson wrote: > From: Magnus Karlsson > > Introduce lazy Tx completions when a queue is used for AF_XDP > zero-copy. In the current design, each time we get into the NAPI poll > loop we try to complete as many Tx packets as possible from the > NIC. This