Re: [PATCH bpf-next] libbpf: emit diff of mismatched public API, if any

2019-05-22 Thread Stanislav Fomichev
On 05/22, Andrii Nakryiko wrote: > On Wed, May 22, 2019 at 9:46 AM Stanislav Fomichev wrote: > > > > On 05/22, Alexei Starovoitov wrote: > > > On 5/22/19 9:15 AM, Andrii Nakryiko wrote: > > > > It's easy to have a mismatch of "intended to be public" vs really > > > > exposed API functions. While M

Re: [PATCH bpf-next] libbpf: emit diff of mismatched public API, if any

2019-05-22 Thread Andrii Nakryiko
On Wed, May 22, 2019 at 9:46 AM Stanislav Fomichev wrote: > > On 05/22, Alexei Starovoitov wrote: > > On 5/22/19 9:15 AM, Andrii Nakryiko wrote: > > > It's easy to have a mismatch of "intended to be public" vs really > > > exposed API functions. While Makefile does check for this mismatch, if > >

Re: [PATCH bpf-next] libbpf: emit diff of mismatched public API, if any

2019-05-22 Thread Andrii Nakryiko
On Wed, May 22, 2019 at 9:21 AM Alexei Starovoitov wrote: > > On 5/22/19 9:15 AM, Andrii Nakryiko wrote: > > It's easy to have a mismatch of "intended to be public" vs really > > exposed API functions. While Makefile does check for this mismatch, if > > it actually occurs it's not trivial to deter

Re: [PATCH bpf-next] libbpf: emit diff of mismatched public API, if any

2019-05-22 Thread Stanislav Fomichev
On 05/22, Alexei Starovoitov wrote: > On 5/22/19 9:15 AM, Andrii Nakryiko wrote: > > It's easy to have a mismatch of "intended to be public" vs really > > exposed API functions. While Makefile does check for this mismatch, if > > it actually occurs it's not trivial to determine which functions are

Re: [PATCH bpf-next] libbpf: emit diff of mismatched public API, if any

2019-05-22 Thread Alexei Starovoitov
On 5/22/19 9:15 AM, Andrii Nakryiko wrote: > It's easy to have a mismatch of "intended to be public" vs really > exposed API functions. While Makefile does check for this mismatch, if > it actually occurs it's not trivial to determine which functions are > accidentally exposed. This patch dumps out