Re: [PATCH bpf-next] bpf: don't check against device MTU in __bpf_skb_max_len

2020-09-16 Thread Toke Høiland-Jørgensen
Maciej Żenczykowski writes: > On Tue, Sep 15, 2020 at 1:47 AM Toke Høiland-Jørgensen > wrote: >> >> [ just jumping in to answer this bit: ] >> >> > Would you happen to know what ebpf startup overhead is? >> > How big a problem is having two (or more) back to back tc programs >> > instead of one

Re: [PATCH bpf-next] bpf: don't check against device MTU in __bpf_skb_max_len

2020-09-15 Thread Toke Høiland-Jørgensen
[ just jumping in to answer this bit: ] > Would you happen to know what ebpf startup overhead is? > How big a problem is having two (or more) back to back tc programs > instead of one? With a jit'ed BPF program and the in-kernel dispatcher code (which avoids indirect calls), it's quite close to a

Re: [PATCH bpf-next] bpf: don't check against device MTU in __bpf_skb_max_len

2020-09-14 Thread Jesper Dangaard Brouer
Hi Maze, Thanks for getting back to me, I appreciate that a lot. More inline below: On Thu, 10 Sep 2020 13:00:12 -0700 Maciej Żenczykowski wrote: > All recent Android R common kernels are currently carrying the > following divergence from upstream: > > https://android.googlesource.com/kernel

Re: [PATCH bpf-next] bpf: don't check against device MTU in __bpf_skb_max_len

2020-09-07 Thread Jesper Dangaard Brouer
On Fri, 4 Sep 2020 16:39:47 -0700 Jakub Kicinski wrote: > On Fri, 04 Sep 2020 11:30:28 +0200 Jesper Dangaard Brouer wrote: > > @@ -3211,8 +3211,7 @@ static int bpf_skb_net_shrink(struct sk_buff *skb, > > u32 off, u32 len_diff, > > > > static u32 __bpf_skb_max_len(const struct sk_buff *skb) >

Re: [PATCH bpf-next] bpf: don't check against device MTU in __bpf_skb_max_len

2020-09-04 Thread Jakub Kicinski
On Fri, 04 Sep 2020 11:30:28 +0200 Jesper Dangaard Brouer wrote: > @@ -3211,8 +3211,7 @@ static int bpf_skb_net_shrink(struct sk_buff *skb, u32 > off, u32 len_diff, > > static u32 __bpf_skb_max_len(const struct sk_buff *skb) > { > - return skb->dev ? skb->dev->mtu + skb->dev->hard_header_l