Re: [PATCH RFC] netlabel: remove unused param from audit_log_format()

2020-08-27 Thread Paul Moore
On Thu, Aug 27, 2020 at 1:20 PM Alex Dewar wrote: > On Thu, Aug 27, 2020 at 06:06:34PM +0100, Alex Dewar wrote: > > On Thu, Aug 27, 2020 at 01:00:58PM -0400, Paul Moore wrote: > > > On Thu, Aug 27, 2020 at 12:39 PM Alex Dewar > > > wrote: > > > > > > > > Commit d3b990b7f327 ("netlabel: fix probl

Re: [PATCH RFC] netlabel: remove unused param from audit_log_format()

2020-08-27 Thread Alex Dewar
On Thu, Aug 27, 2020 at 06:06:34PM +0100, Alex Dewar wrote: > On Thu, Aug 27, 2020 at 01:00:58PM -0400, Paul Moore wrote: > > On Thu, Aug 27, 2020 at 12:39 PM Alex Dewar wrote: > > > > > > Commit d3b990b7f327 ("netlabel: fix problems with mapping removal") > > > added a check to return an error if

Re: [PATCH RFC] netlabel: remove unused param from audit_log_format()

2020-08-27 Thread Alex Dewar
On Thu, Aug 27, 2020 at 01:00:58PM -0400, Paul Moore wrote: > On Thu, Aug 27, 2020 at 12:39 PM Alex Dewar wrote: > > > > Commit d3b990b7f327 ("netlabel: fix problems with mapping removal") > > added a check to return an error if ret_val != 0, before ret_val is > > later used in a log message. Now

Re: [PATCH RFC] netlabel: remove unused param from audit_log_format()

2020-08-27 Thread Paul Moore
On Thu, Aug 27, 2020 at 12:39 PM Alex Dewar wrote: > > Commit d3b990b7f327 ("netlabel: fix problems with mapping removal") > added a check to return an error if ret_val != 0, before ret_val is > later used in a log message. Now it will unconditionally print "... > res=0". So don't print res anymor