Re: [kbuild-all] Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-15 Thread Rong Chen
On 12/12/20 4:47 PM, Philip Li wrote: On Thu, Dec 10, 2020 at 12:41:32PM +, Geva, Erez wrote: On 10/12/2020 04:11, kernel test robot wrote: Hi Erez, Thank you for the patch! Yet something to improve: Thanks for the robot, as we rarely use clang for kernel. It is very helpful. [auto

Re: [kbuild-all] Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-12 Thread Philip Li
On Thu, Dec 10, 2020 at 12:41:32PM +, Geva, Erez wrote: > > On 10/12/2020 04:11, kernel test robot wrote: > > Hi Erez, > > > > Thank you for the patch! Yet something to improve: > > > Thanks for the robot, > as we rarely use clang for kernel. It is very helpful. > > > [auto build test ERROR

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-11 Thread Willem de Bruijn
> >> I did not use "Fair Queue traffic policing". > >> As for ETF, it is all about ordering packets from different > >> applications. > >> How can we achive it with skiping queuing? > >> Could you elaborate on this point? > >> >>> > >> >>> The qdisc can only defer pacing t

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-11 Thread Geva, Erez
On 11/12/2020 01:27, Vinicius Costa Gomes wrote: > Willem de Bruijn writes: > If I understand correctly, you are trying to achieve a single delivery time. The need for two separate timestamps passed along is only because the kernel is unable to do the time base conversion. >>

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-11 Thread Geva, Erez
On 11/12/2020 00:30, Willem de Bruijn wrote: >>> If I understand correctly, you are trying to achieve a single delivery time. >>> The need for two separate timestamps passed along is only because the >>> kernel is unable to do the time base conversion. >> >> Yes, a correct point. >> >>> >>> Else,

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-10 Thread Vinicius Costa Gomes
Willem de Bruijn writes: >> > If I understand correctly, you are trying to achieve a single delivery >> > time. >> > The need for two separate timestamps passed along is only because the >> > kernel is unable to do the time base conversion. >> >> Yes, a correct point. >> >> > >> > Else, ETF coul

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-10 Thread Willem de Bruijn
> > If I understand correctly, you are trying to achieve a single delivery time. > > The need for two separate timestamps passed along is only because the > > kernel is unable to do the time base conversion. > > Yes, a correct point. > > > > > Else, ETF could program the qdisc watchdog in system ti

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-10 Thread Geva, Erez
On 10/12/2020 20:11, Willem de Bruijn wrote: > On Wed, Dec 9, 2020 at 3:18 PM Geva, Erez wrote: >> >> >> On 09/12/2020 18:37, Willem de Bruijn wrote: >>> On Wed, Dec 9, 2020 at 10:25 AM Geva, Erez >>> wrote: On 09/12/2020 15:48, Willem de Bruijn wrote: > On Wed, Dec 9, 2020 a

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-10 Thread Willem de Bruijn
On Wed, Dec 9, 2020 at 3:18 PM Geva, Erez wrote: > > > On 09/12/2020 18:37, Willem de Bruijn wrote: > > On Wed, Dec 9, 2020 at 10:25 AM Geva, Erez > > wrote: > >> > >> > >> On 09/12/2020 15:48, Willem de Bruijn wrote: > >>> On Wed, Dec 9, 2020 at 9:37 AM Erez Geva > >>> wrote: > > Co

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-10 Thread Geva, Erez
On 10/12/2020 13:33, Geva, Erez (ext) (DI PA CI R&D 3) wrote: > > On 10/12/2020 04:11, kernel test robot wrote: >> Hi Erez, >> >> Thank you for the patch! Yet something to improve: >> > Thanks for the robot, > as we rarely use clang for kernel. It is very helpful. > >> [auto build test ERROR on

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-10 Thread Geva, Erez
On 10/12/2020 04:11, kernel test robot wrote: > Hi Erez, > > Thank you for the patch! Yet something to improve: > Thanks for the robot, as we rarely use clang for kernel. It is very helpful. > [auto build test ERROR on b65054597872ce3aefbc6a666385eabdf9e288da] > > url: > https://github.co

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-09 Thread kernel test robot
Hi Erez, Thank you for the patch! Yet something to improve: [auto build test ERROR on b65054597872ce3aefbc6a666385eabdf9e288da] url: https://github.com/0day-ci/linux/commits/Erez-Geva/Add-sending-TX-hardware-timestamp-for-TC-ETF-Qdisc/20201210-000521 base:b65054597872ce3aefbc6a666385eabd

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-09 Thread Geva, Erez
On 09/12/2020 18:37, Willem de Bruijn wrote: > On Wed, Dec 9, 2020 at 10:25 AM Geva, Erez wrote: >> >> >> On 09/12/2020 15:48, Willem de Bruijn wrote: >>> On Wed, Dec 9, 2020 at 9:37 AM Erez Geva wrote: Configure and send TX sending hardware timestamp from user space applicatio

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-09 Thread Willem de Bruijn
On Wed, Dec 9, 2020 at 10:25 AM Geva, Erez wrote: > > > On 09/12/2020 15:48, Willem de Bruijn wrote: > > On Wed, Dec 9, 2020 at 9:37 AM Erez Geva wrote: > >> > >> Configure and send TX sending hardware timestamp from > >> user space application to the socket layer, > >> to provide to the TC E

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-09 Thread Geva, Erez
On 09/12/2020 15:48, Willem de Bruijn wrote: > On Wed, Dec 9, 2020 at 9:37 AM Erez Geva wrote: >> >> Configure and send TX sending hardware timestamp from >> user space application to the socket layer, >> to provide to the TC ETC Qdisc, and pass it to >> the interface network driver. >> >>

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-09 Thread Willem de Bruijn
On Wed, Dec 9, 2020 at 9:37 AM Erez Geva wrote: > > Configure and send TX sending hardware timestamp from > user space application to the socket layer, > to provide to the TC ETC Qdisc, and pass it to > the interface network driver. > > - New flag for the SO_TXTIME socket option. > - New acce