Re: [PATCH] virtio_net: Use u64_stats_fetch_begin() for stats fetch

On Wed, Jun 19, 2024 at 10:55:29AM +0800, Li RongQing wrote: > This place is fetching the stats, so u64_stats_fetch_begin > and u64_stats_fetch_retry should be used > > Fixes: 6208799553a8 ("virtio-net: support rx netdim") > Signed-off-by: Li RongQing So I dropped this from my tree, if you think

RE: [????] Re: [PATCH] virtio_net: Use u64_stats_fetch_begin() for stats fetch

> Did you by any chance use an automated tool of any sort to find this issue or > generate the fix? > > I don't think this is actually necessary here, you're in the same context as > the > updater of the stats, you don't need any protection. > You can remove u64_stats_update_begin() / end() (in n

Re: [PATCH] virtio_net: Use u64_stats_fetch_begin() for stats fetch

On Thu, Jun 20, 2024 at 07:09:08AM -0700, Jakub Kicinski wrote: > On Wed, 19 Jun 2024 10:55:29 +0800 Li RongQing wrote: > > This place is fetching the stats, so u64_stats_fetch_begin > > and u64_stats_fetch_retry should be used > > > > Fixes: 6208799553a8 ("virtio-net: support rx netdim") > > Sign

Re: [PATCH] virtio_net: Use u64_stats_fetch_begin() for stats fetch

On Wed, 19 Jun 2024 10:55:29 +0800 Li RongQing wrote: > This place is fetching the stats, so u64_stats_fetch_begin > and u64_stats_fetch_retry should be used > > Fixes: 6208799553a8 ("virtio-net: support rx netdim") > Signed-off-by: Li RongQing > --- > drivers/net/virtio_net.c | 14 -

Re: [PATCH] virtio_net: Use u64_stats_fetch_begin() for stats fetch

On Wed, Jun 19, 2024 at 10:56 AM Li RongQing wrote: > > This place is fetching the stats, so u64_stats_fetch_begin > and u64_stats_fetch_retry should be used > > Fixes: 6208799553a8 ("virtio-net: support rx netdim") > Signed-off-by: Li RongQing Acked-by: Jason Wang Thanks

Re: [PATCH] virtio_net: Use u64_stats_fetch_begin() for stats fetch

On Wed, Jun 19, 2024 at 10:55:29AM +0800, Li RongQing wrote: > This place is fetching the stats, so u64_stats_fetch_begin > and u64_stats_fetch_retry should be used > > Fixes: 6208799553a8 ("virtio-net: support rx netdim") > Signed-off-by: Li RongQing Acked-by: Michael S. Tsirkin > --- > driv

Re: [PATCH] virtio_net: Use u64_stats_fetch_begin() for stats fetch

Wed, Jun 19, 2024 at 04:55:29AM CEST, lirongq...@baidu.com wrote: >This place is fetching the stats, so u64_stats_fetch_begin >and u64_stats_fetch_retry should be used > >Fixes: 6208799553a8 ("virtio-net: support rx netdim") >Signed-off-by: Li RongQing Reviewed-by: Jiri Pirko

Re: [PATCH] virtio_net: Use u64_stats_fetch_begin() for stats fetch

On Wed, 19 Jun 2024 10:55:29 +0800, Li RongQing wrote: > This place is fetching the stats, so u64_stats_fetch_begin > and u64_stats_fetch_retry should be used Reviewed-by: Heng Qi Thanks! > > Fixes: 6208799553a8 ("virtio-net: support rx netdim") > Signed-off-by: Li RongQing > --- > drivers/