Re: [PATCH] [RFC] net: phy: smsc: Add magnetics VIO regulator support

2021-01-05 Thread Marek Vasut
On 1/5/21 8:03 PM, Andrew Lunn wrote: On Tue, Jan 05, 2021 at 06:53:48PM +0100, Marek Vasut wrote: On 1/5/21 6:38 PM, Andrew Lunn wrote: +static void smsc_link_change_notify(struct phy_device *phydev) +{ + struct smsc_phy_priv *priv = phydev->priv; + + if (!priv->vddio) +

Re: [PATCH] [RFC] net: phy: smsc: Add magnetics VIO regulator support

2021-01-05 Thread Andrew Lunn
On Tue, Jan 05, 2021 at 06:53:48PM +0100, Marek Vasut wrote: > On 1/5/21 6:38 PM, Andrew Lunn wrote: > > > +static void smsc_link_change_notify(struct phy_device *phydev) > > > +{ > > > + struct smsc_phy_priv *priv = phydev->priv; > > > + > > > + if (!priv->vddio) > > > + return; > > > + >

Re: [PATCH] [RFC] net: phy: smsc: Add magnetics VIO regulator support

2021-01-05 Thread Marek Vasut
On 1/5/21 6:38 PM, Andrew Lunn wrote: +static void smsc_link_change_notify(struct phy_device *phydev) +{ + struct smsc_phy_priv *priv = phydev->priv; + + if (!priv->vddio) + return; + + if (phydev->state == PHY_HALTED) + regulator_disable(priv->vddio)

Re: [PATCH] [RFC] net: phy: smsc: Add magnetics VIO regulator support

2021-01-05 Thread Andrew Lunn
> +static void smsc_link_change_notify(struct phy_device *phydev) > +{ > + struct smsc_phy_priv *priv = phydev->priv; > + > + if (!priv->vddio) > + return; > + > + if (phydev->state == PHY_HALTED) > + regulator_disable(priv->vddio); > + > + if (phydev->state