Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Mon, 29 Mar 2021 12:23:54 +0100 you wrote:
> From: Colin Ian King
>
> The variable res is being initialized with a value that is
> never read and it is being updated later with a new value.
> The in
From: Colin Ian King
The variable res is being initialized with a value that is
never read and it is being updated later with a new value.
The initialization is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King
---
drivers/net/
size_t sub## _ ##name## _read(struct file *file,
\
struct wl1271 *wl = file->private_data; \
struct struct_type *stats = wl->stats.fw_stats; \
char buf[DEBUGFS_FORMAT_BUFFER_SIZE] = "";
From: Andrew Lunn
Date: Sun, 5 Jul 2020 22:55:55 +0200
> Since lan9303_adjust_link() is a void function, there is no option to
> return an error. So just remove the variable and lets any errors be
> discarded.
>
> Cc: Egil Hjelmeland
> Signed-off-by: Andrew Lunn
Applied to net-next.
From: Andrew Lunn
Date: Sun, 5 Jul 2020 22:55:55 +0200
> Since lan9303_adjust_link() is a void function, there is no option to
> return an error. So just remove the variable and lets any errors be
> discarded.
>
> Cc: Egil Hjelmeland
> Signed-off-by: Andrew Lunn
Applied to net-next.
On 7/5/2020 1:55 PM, Andrew Lunn wrote:
> Since lan9303_adjust_link() is a void function, there is no option to
> return an error. So just remove the variable and lets any errors be
> discarded.
>
> Cc: Egil Hjelmeland
> Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
,
struct phy_device *phydev)
{
struct lan9303 *chip = ds->priv;
- int ctl, res;
+ int ctl;
if (!phy_is_pseudo_fixed_link(phydev))
return;
@@ -1063,15 +1063,14 @@ static void lan9303_adjust_link(struct dsa_switch *ds,
int port,
e
De: José Luiz Fabris
Enviado: terça-feira, 30 de julho de 2019 18:37
Para: José Luiz Fabris
Assunto: PROPOSAL.
Good Day,
I am Mrs.Margaret Ko May-Yee Leung Deputy Managing Director and Executive
Director of Chong Hing Bank Limited. I write briefly to
After proper and several investigations and research at Western Union, we found
your Email address in Western Union database among those that have been
mandated to receive a compensation of $1,200,000.00 via Western Union by the
United Nation . Please provide any of the information below in refe
*res;
struct tc_u32_sel *sel;
u32 handle;
u32 val;
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
index 4b28fd44576d..4c54bc440798 100644
--- a/net/sched/cls_u32.c
+++ b/net/sched/cls_u32.c
@@ -558,6 +558,7 @@ static int u32_replace_hw_knode(struct tcf_proto *tp
On Mon, Aug 13, 2018 at 3:44 AM Hangbin Liu wrote:
> This is because we didn't update f->result.res when create new filter. Then in
> tcindex_delete() -> tcf_unbind_filter(), we will failed to find out the res
> and unbind filter, which will trigger the WARN_ON() in cbq_dest
R15:
[ 733.870121] ---[ end trace 28edd4aad712ddca ]---
This is because we didn't update f->result.res when create new filter. Then in
tcindex_delete() -> tcf_unbind_filter(), we will failed to find out the res
and unbind filter, which will trigger the WARN_ON() in cbq_d
From: Roopa Prabhu
Date: Wed, 16 Aug 2017 12:38:52 -0700
> From: Roopa Prabhu
>
> Syzkaller hit 'general protection fault in fib_dump_info' bug on
> commit 4.13-rc5..
>
> Guilty file: net/ipv4/fib_semantics.c
...
> This patch adds a res->fi NULL check.
0 fc ff df 48 89 fa 48 c1 ea 03
<0f>
b6 04 02 84 c0 74 08 3c 03 0f 8e cb 0c 00 00 48 8b 45 28 44
RIP: fib_dump_info+0x388/0x1170 net/ipv4/fib_semantics.c:1314 RSP:
880078117010
---[ end trace 254a7af28348f88b ]---
This patch adds a res->fi NULL check.
example run:
$ip route get
m_flags & RTM_F_FIB_MATCH) {
>> + if (!res.fi) {
>> + err = fib_props[res->type].error;
>> + if (!err)
>> + err = -EINVAL;
>
> I think -EHOSTUNREACH is a better error than EINVAL. Nothing
h,
> if (rtm->rtm_flags & RTM_F_LOOKUP_TABLE)
> table_id = rt->rt_table_id;
>
> - if (rtm->rtm_flags & RTM_F_FIB_MATCH)
> + if (rtm->rtm_flags & RTM_F_FIB_MATCH) {
> + if (!res.fi) {
> + err
0 00 00 00 fc ff df 48 89 fa 48 c1 ea 03
<0f>
b6 04 02 84 c0 74 08 3c 03 0f 8e cb 0c 00 00 48 8b 45 28 44
RIP: fib_dump_info+0x388/0x1170 net/ipv4/fib_semantics.c:1314 RSP:
880078117010
This patch adds a res->fi NULL check.
example run:
$ip route get 0.0.0.0 iif virt1-
From: Ivan Khoronzhuk
Date: Thu, 19 Jan 2017 18:58:22 +0200
> This series is intended to remove unneeded redundancies connected with
> common resource usage function.
>
> Since v1:
> - changed name to cpsw_get_usage_count()
> - added comments to open/closw for cpsw_get_usage_count()
> - added pa
: cpsw: clarify ethtool ops changing num of descs
Based on net-next/master
Ivan Khoronzhuk (5):
net: ethernet: ti: cpsw: remove dual check from common res usage
function
net: ethernet: ti: cpsw: don't disable interrupts in ndo_open
net: ethernet: ti: cpsw: don't duplicate nd
Common res usage is possible only in case an interface is
running. In case of not dual emac here can be only one interface,
so while ndo_open and switch mode, only one interface can be opened,
thus if open is called no any interface is running ... and no common
res are used. So remove check on
No need to duplicate the same function in rx handler to get info
if any interface is running.
Signed-off-by: Ivan Khoronzhuk
---
drivers/net/ethernet/ti/cpsw.c | 40
1 file changed, 16 insertions(+), 24 deletions(-)
diff --git a/drivers/net/ethernet/ti/c
Based on net-next/master
Ivan Khoronzhuk (5):
net: ethernet: ti: cpsw: remove dual check from common res usage
function
net: ethernet: ti: cpsw: don't disable interrupts in ndo_open
net: ethernet: ti: cpsw: don't duplicate ndev_running
net: ethernet: ti: cpsw: don't dupli
Hi Ivan,
On 01/08/2017 10:40 AM, Ivan Khoronzhuk wrote:
This series is intended to remove unneeded redundancies connected with
common resource usage function.
Based on net-next/master
Tested on am572x idk
Ivan Khoronzhuk (4):
net: ethernet: ti: cpsw: remove dual check from common res usage
This series is intended to remove unneeded redundancies connected with
common resource usage function.
Based on net-next/master
Tested on am572x idk
Ivan Khoronzhuk (4):
net: ethernet: ti: cpsw: remove dual check from common res usage
function
net: ethernet: ti: cpsw: don't di
Common res usage is possible only in case an interface is
running. In case of not dual emac here can be only one interface,
so while ndo_open and switch mode, only one interface can be opened,
thus if open is called no any interface is running ... and no common
res are used. So remove check on
No need to duplicate the same function in rx handler to get info
if any interface is running.
Signed-off-by: Ivan Khoronzhuk
---
drivers/net/ethernet/ti/cpsw.c | 40
1 file changed, 16 insertions(+), 24 deletions(-)
diff --git a/drivers/net/ethernet/ti/c
Please ignore it, I've included it in new series
On Sun, Jan 08, 2017 at 03:56:27PM +0200, Ivan Khoronzhuk wrote:
> Common res usage is possible only in case an interface is
> running. In case of not dual emac here can be only one interface,
> so while ndo_open and switch mode, only
Common res usage is possible only in case an interface is
running. In case of not dual emac here can be only one interface,
so while ndo_open and switch mode, only one interface can be opened,
thus if open is called no any interface is running ... and no common
res are used. So remove check on
From: Ivan Khoronzhuk
Date: Sat, 10 Dec 2016 14:23:49 +0200
> Don't re-split res in the following cases:
> - speed of phys is not changed
> - speed of phys is changed and no rate limited channels
> - speed of phys is changed and all channels are rate limited
> - phy is unlink
Don't re-split res in the following cases:
- speed of phys is not changed
- speed of phys is changed and no rate limited channels
- speed of phys is changed and all channels are rate limited
- phy is unlinked while dev is open
- phy is linked back but speed is not changed
The maximum speed i
From: Jack Morgenstein
The resource type enum in the resource tracker was incorrect.
RES_EQ was put in the position of RES_NPORT_ID (a FC resource).
Since the remaining resources maintain their current values,
and RES_EQ is not passed from slaves to the hypervisor in any
FW command, this change
benet/be.h
@@ -570,6 +570,8 @@ struct be_adapter {
struct be_resources pool_res; /* resources available for the port */
struct be_resources res;/* resources available for the func */
u16 num_vfs;/* Number of VFs provisioned by PF
benet/be.h
@@ -570,6 +570,8 @@ struct be_adapter {
struct be_resources pool_res; /* resources available for the port */
struct be_resources res;/* resources available for the func */
u16 num_vfs;/* Number of VFs provisioned by PF
benet/be.h
@@ -570,6 +570,8 @@ struct be_adapter {
struct be_resources pool_res; /* resources available for the port */
struct be_resources res;/* resources available for the func */
u16 num_vfs;/* Number of VFs provisioned by PF
34 matches
Mail list logo
