RE: sctp: num_ostreams and max_instreams negotiation

2020-08-18 Thread David Laight
From: Marcelo Ricardo Leitner > Sent: 17 August 2020 15:36 .. > > The proper fix here is to move back to the original if() condition, > > and put genradix_prealloc() inside it again, as was fa_zero() before. > > The if() is not strictly needed, because genradix_prealloc() will > > handle it nicely,

Re: sctp: num_ostreams and max_instreams negotiation

2020-08-17 Thread Marcelo Ricardo Leitner
On Mon, Aug 17, 2020 at 11:22:23AM -0300, Marcelo Ricardo Leitner wrote: > On Sat, Aug 15, 2020 at 02:49:31PM +, David Laight wrote: > > From: David Laight > > > Sent: 14 August 2020 17:18 > > > > > > > > > At some point the negotiation of the number of SCTP streams > > > > > > seems to have g

Re: sctp: num_ostreams and max_instreams negotiation

2020-08-17 Thread Marcelo Ricardo Leitner
On Sat, Aug 15, 2020 at 02:49:31PM +, David Laight wrote: > From: David Laight > > Sent: 14 August 2020 17:18 > > > > > > > At some point the negotiation of the number of SCTP streams > > > > > seems to have got broken. > > > > > I've definitely tested it in the past (probably 10 years ago!) >

RE: sctp: num_ostreams and max_instreams negotiation

2020-08-15 Thread David Laight
From: David Laight > Sent: 14 August 2020 17:18 > > > > > At some point the negotiation of the number of SCTP streams > > > > seems to have got broken. > > > > I've definitely tested it in the past (probably 10 years ago!) > > > > but on a 5.8.0 kernel getsockopt(SCTP_INFO) seems to be > > > > ret

RE: sctp: num_ostreams and max_instreams negotiation

2020-08-14 Thread David Laight
> > > At some point the negotiation of the number of SCTP streams > > > seems to have got broken. > > > I've definitely tested it in the past (probably 10 years ago!) > > > but on a 5.8.0 kernel getsockopt(SCTP_INFO) seems to be > > > returning the 'num_ostreams' set by setsockopt(SCTP_INIT) > > >

RE: sctp: num_ostreams and max_instreams negotiation

2020-08-14 Thread David Laight
> > At some point the negotiation of the number of SCTP streams > > seems to have got broken. > > I've definitely tested it in the past (probably 10 years ago!) > > but on a 5.8.0 kernel getsockopt(SCTP_INFO) seems to be > > returning the 'num_ostreams' set by setsockopt(SCTP_INIT) > > rather than