Re: pull-request: mac80211 2021-01-18.2

2021-01-26 Thread Hans de Goede
Hi, On 1/25/21 1:40 PM, Johannes Berg wrote: > Hi, > >>> I don't have that much sympathy for a staging driver that's clearly >>> doing things differently than it was intended (the documentation states >>> that the function should be called only before wiphy_register(), not >>> during ndo_open). :

Re: pull-request: mac80211 2021-01-18.2

2021-01-26 Thread Johannes Berg
On Mon, 2021-01-25 at 13:59 +0100, Hans de Goede wrote: > Yes this fixes things, thank you that saves me from having to debug > the NULL ptr deref. :) > Do you want to submit this to Greg, or shall I (I've already > added it to me local tree as a commit with you as the author) ? > > If you want

Re: pull-request: mac80211 2021-01-18.2

2021-01-26 Thread Hans de Goede
Hi, On 1/25/21 10:47 AM, Johannes Berg wrote: > Hi, > > Sorry, apparently we have two threads. > >> Great, thank you for looking into this. Let me know if you have a patch >> which you want me to test on a RTL8723BS adapter. > > Could you test this instead? > > https://p.sipsolutions.net/235c3

Re: pull-request: mac80211 2021-01-18.2

2021-01-25 Thread Johannes Berg
Hi, > > I don't have that much sympathy for a staging driver that's clearly > > doing things differently than it was intended (the documentation states > > that the function should be called only before wiphy_register(), not > > during ndo_open). :-) > > I completely understand and I already was

Re: pull-request: mac80211 2021-01-18.2

2021-01-25 Thread Johannes Berg
Hi, Sorry, apparently we have two threads. > Great, thank you for looking into this. Let me know if you have a patch > which you want me to test on a RTL8723BS adapter. Could you test this instead? https://p.sipsolutions.net/235c352b8ae5db88.txt I don't have that much sympathy for a staging d

RE: pull-request: mac80211 2021-01-18.2

2021-01-24 Thread Peer, Ilan
Hi, > Great, thank you for looking into this. Let me know if you have a patch which > you want me to test on a RTL8723BS adapter. > > One thing which I forgot to mention earlier, it is not just lockdep > complaining > this appears to be a real deadlock, the wifi no longer functions, where as it

Re: pull-request: mac80211 2021-01-18.2

2021-01-24 Thread Hans de Goede
Hi, On 1/24/21 10:12 AM, Peer, Ilan wrote: >> -Original Message- >> From: Johannes Berg >> Sent: Sunday, January 24, 2021 00:16 >> To: Hans de Goede ; netdev@vger.kernel.org >> Cc: linux-wirel...@vger.kernel.org; Peer, Ilan ; >> Coelho, Luciano &g

RE: pull-request: mac80211 2021-01-18.2

2021-01-24 Thread Peer, Ilan
> -Original Message- > From: Johannes Berg > Sent: Sunday, January 24, 2021 00:16 > To: Hans de Goede ; netdev@vger.kernel.org > Cc: linux-wirel...@vger.kernel.org; Peer, Ilan ; > Coelho, Luciano > Subject: Re: pull-request: mac80211 2021-01-18.2 > > On Sat

Re: pull-request: mac80211 2021-01-18.2

2021-01-23 Thread Johannes Berg
On Sat, 2021-01-23 at 22:31 +0100, Hans de Goede wrote: > > So I'm afraid that I have some bad news about this patch, it fixes > the RCU warning which I reported: > > https://lore.kernel.org/linux-wireless/20210104170713.66956-1-hdego...@redhat.com/ > > But it introduces a deadlock. See: > > ht

Re: pull-request: mac80211 2021-01-18.2

2021-01-23 Thread Hans de Goede
On 1/18/21 9:47 PM, Johannes Berg wrote: > Hi, > > New try, dropped the 160 MHz CSA patch for now that has the sparse > issue since people are waiting for the kernel-doc fixes. > > Please pull and let me know if there's any problem. > > Thanks, > johannes > > > > The following changes sinc

Re: pull-request: mac80211 2021-01-18.2

2021-01-20 Thread Johannes Berg
On Wed, 2021-01-20 at 12:37 -0800, Jakub Kicinski wrote: > On Wed, 20 Jan 2021 18:59:21 +0100 Johannes Berg wrote: > > Hi Jakub, > > > > > This pull request was applied to netdev/net.git (refs/heads/master): > > > > Since you pulled this now, question: > > > > I have some pending content for m

Re: pull-request: mac80211 2021-01-18.2

2021-01-20 Thread Jakub Kicinski
On Wed, 20 Jan 2021 18:59:21 +0100 Johannes Berg wrote: > Hi Jakub, > > > This pull request was applied to netdev/net.git (refs/heads/master): > > Since you pulled this now, question: > > I have some pending content for mac80211-next/net-next that either > conflicts with or requires a fix from

Re: pull-request: mac80211 2021-01-18.2

2021-01-20 Thread Johannes Berg
Hi Jakub, > This pull request was applied to netdev/net.git (refs/heads/master): Since you pulled this now, question: I have some pending content for mac80211-next/net-next that either conflicts with or requires a fix from here, or such. Could you pull net into net-next, so I can get it into ma

Re: pull-request: mac80211 2021-01-18.2

2021-01-18 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net.git (refs/heads/master): On Mon, 18 Jan 2021 21:47:49 +0100 you wrote: > Hi, > > New try, dropped the 160 MHz CSA patch for now that has the sparse > issue since people are waiting for the kernel-doc fixes. > > Please pull and let me know if th