RE: New Qlogic qla3xxx NIC Driver v2.02.00k34 for upstream inclusion

2006-06-23 Thread Ron Mercer
> Ron Mercer wrote: > >> 9) [minor] "N/A" appears to be an inaccurate value for > fw_version in > >> ql_get_drvinfo() > > > > Does anyone know what would be appropriate for this ethtool > command? > > My device does not use firmware. I took the "N/A" idea > from e1000 and > > skge. > >

Re: New Qlogic qla3xxx NIC Driver v2.02.00k34 for upstream inclusion

2006-06-23 Thread Jeff Garzik
Ron Mercer wrote: 9) [minor] "N/A" appears to be an inaccurate value for fw_version in ql_get_drvinfo() Does anyone know what would be appropriate for this ethtool command? My device does not use firmware. I took the "N/A" idea from e1000 and skge. It does both ethernet and iSCSI entirely i

RE: New Qlogic qla3xxx NIC Driver v2.02.00k34 for upstream inclusion

2006-06-23 Thread Ron Mercer
> 9) [minor] "N/A" appears to be an inaccurate value for fw_version in > ql_get_drvinfo() Does anyone know what would be appropriate for this ethtool command? My device does not use firmware. I took the "N/A" idea from e1000 and skge. - To unsubscribe from this list: send the line "unsubscr

RE: New Qlogic qla3xxx NIC Driver v2.02.00k34 for upstream inclusion

2006-06-23 Thread Ron Mercer
Jeff, I will address all of your points in my next post. > 5) What is the point of using the hardware semaphore? Is a firmware > competing with the device driver somehow, and its activities require > synchronization with the OS driver? >From the body of my previous post: - ql_wait_for_drvr_l

Re: New Qlogic qla3xxx NIC Driver v2.02.00k34 for upstream inclusion

2006-06-22 Thread Jeff Garzik
Roland Dreier wrote: > 15) I wonder if SA_SHIRQ needs to be set, for MSI? Why would it? MSI vectors are always unique, aren't they? Precisely what my question implies... Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PR

Re: New Qlogic qla3xxx NIC Driver v2.02.00k34 for upstream inclusion

2006-06-22 Thread Roland Dreier
> 15) I wonder if SA_SHIRQ needs to be set, for MSI? Why would it? MSI vectors are always unique, aren't they? - R. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.ht

Re: New Qlogic qla3xxx NIC Driver v2.02.00k34 for upstream inclusion

2006-06-22 Thread Jeff Garzik
Ron Mercer wrote: ftp://ftp.qlogic.com/outgoing/linux/network/upstream/2.02.00k34/qla3xxxp atch1-v2.02.00-k34.txt Your mailer breaks this into two lines, which is a pain. Comments on this updated version: 1) [semi-major] Infinite loop in ql_sem_spinlock(), if hardware is faulty or been unplu