Re: New Qlogic qla3xxx NIC Driver v2.02.00k31 for upstream inclusion

2006-06-22 Thread Philip Craig
On 06/22/2006 02:55 PM, Andrew Morton wrote: > - Is there a better way of doing this? > > static void ql_swap_mac_addr(u8 * macAddress) > { > #ifdef __BIG_ENDIAN > u8 temp; > temp = macAddress[0]; > macAddress[0] = macAddress[1]; > macAddress[1] = temp; > temp = macAdd

Re: New Qlogic qla3xxx NIC Driver v2.02.00k31 for upstream inclusion

2006-06-22 Thread Jeff Garzik
Andrew Morton wrote: "Ron Mercer" <[EMAIL PROTECTED]> wrote: Thanks for your feedback. I've fixed everything you mentioned with the exception of the code below. I need to swap every other byte pair of my nvram mac address for big endian systems. Everything else I tried was more messy. Did yo

Re: New Qlogic qla3xxx NIC Driver v2.02.00k31 for upstream inclusion

2006-06-22 Thread Andrew Morton
"Ron Mercer" <[EMAIL PROTECTED]> wrote: > > Thanks for your feedback. I've fixed everything you mentioned with the > exception of the code below. I need to swap every other byte pair of my > nvram mac address for big endian systems. Everything else I tried was > more messy. Did you have anythin

RE: New Qlogic qla3xxx NIC Driver v2.02.00k31 for upstream inclusion

2006-06-22 Thread Ron Mercer
Andrew, Thanks for your feedback. I've fixed everything you mentioned with the exception of the code below. I need to swap every other byte pair of my nvram mac address for big endian systems. Everything else I tried was more messy. Did you have anything specific in mind? Ron Mercer > >

Re: New Qlogic qla3xxx NIC Driver v2.02.00k31 for upstream inclusion

2006-06-21 Thread Andrew Morton
On Wed, 21 Jun 2006 14:24:27 -0700 "Ron Mercer" <[EMAIL PROTECTED]> wrote: > Please add the qla3xxx NIC driver to the next netdev-2.6 GIT tree. - We won't be able to include this withot a Signed-off-by: as per section 11 of Documentation/SubmittingPatches. - The driver does a lot of: static

Re: New Qlogic qla3xxx NIC Driver v2.02.00k31 for upstream inclusion

2006-06-21 Thread Francois Romieu
Ron Mercer <[EMAIL PROTECTED]> : [...] > Please add the qla3xxx NIC driver to the next netdev-2.6 GIT tree. $ less qla3xxxpatch1-v2.02.00-k31.txt [...] + * See LICENSE.qla3xxx for copyright and licensing details. 1 - The patch contains no such file (though the file is MODULE_LICENSE("GPL")).

RE: New Qlogic qla3xxx NIC Driver v2.02.00k31 for upstream inclusion

2006-06-21 Thread Ron Mercer
Jeff, Please add the qla3xxx NIC driver to the next netdev-2.6 GIT tree. Regards, Ron Mercer > -Original Message- > From: Ron Mercer > Sent: Monday, June 12, 2006 1:33 PM > To: '[EMAIL PROTECTED]' > Cc: '[EMAIL PROTECTED]'; 'netdev@vger.kernel.org' > Subject: New Qlogic qla3xxx NIC Dri