RE: Marvell Phy (1510) issue since v4.7 kernel

2017-01-12 Thread Kwok, WingMan
Hi Andrew, > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Thursday, January 12, 2017 4:50 PM > To: Kwok, WingMan > Cc: rmk+ker...@arm.linux.org.uk; Karicheri, Muralidharan; > netdev@vger.kernel.org > Subject: Re: Marvell Phy (1510) is

RE: Marvell Phy (1510) issue since v4.7 kernel

2017-01-12 Thread Kwok, WingMan
> -Original Message- > From: Russell King - ARM Linux [mailto:li...@armlinux.org.uk] > Sent: Thursday, January 12, 2017 4:42 PM > To: Kwok, WingMan > Cc: Andrew Lunn; Karicheri, Muralidharan; netdev@vger.kernel.org > Subject: Re: Marvell Phy (1510) issue since v4.7

Re: Marvell Phy (1510) issue since v4.7 kernel

2017-01-12 Thread Russell King - ARM Linux
On Thu, Jan 12, 2017 at 10:49:41PM +0100, Andrew Lunn wrote: > How are you using the PHY. What phy-mode do you have set? Do you > happen to be using it as an RGMII to SERDES/SGMII bridge? This is what > Russell King is doing, i think. No - the 88E1512 here is connected to the ethernet host via SG

Re: Marvell Phy (1510) issue since v4.7 kernel

2017-01-12 Thread Andrew Lunn
> But our problem is caused by the read_status function: > > if ((phydev->supported & SUPPORTED_FIBRE)) { > err = phy_write(phydev, MII_MARVELL_PHY_PAGE, MII_M_FIBER); > if (err < 0) > goto error; > > err = ma

Re: Marvell Phy (1510) issue since v4.7 kernel

2017-01-12 Thread Russell King - ARM Linux
On Thu, Jan 12, 2017 at 09:31:27PM +, Kwok, WingMan wrote: > > > > I double checked that ours is actually a 88E1514. According > > > to Marvell's brief description, it seems that it does support > > > fiber. > > > > > > Reading page 18 reg 30 returns 6. > > > > O.K, that is consistent. Lookin

RE: Marvell Phy (1510) issue since v4.7 kernel

2017-01-12 Thread Kwok, WingMan
> > I double checked that ours is actually a 88E1514. According > > to Marvell's brief description, it seems that it does support > > fiber. > > > > Reading page 18 reg 30 returns 6. > > O.K, that is consistent. Looking at the Marvell SDK: > > phy/Include/madApiDefs.h:#defineMAD_SUB_88E1510

RE: Marvell Phy (1510) issue since v4.7 kernel

2017-01-11 Thread Kwok, WingMan
> -Original Message- > From: Kwok, WingMan > Sent: Wednesday, January 11, 2017 5:32 PM > To: 'Andrew Lunn'; 'rmk+ker...@arm.linux.org.uk' > Cc: Karicheri, Muralidharan; netdev@vger.kernel.org > Subject: RE: Marvell Phy (1510) issue since v4.7 ker

Re: Marvell Phy (1510) issue since v4.7 kernel

2017-01-11 Thread Andrew Lunn
> Hi Andrew, > > I double checked that ours is actually a 88E1514. According > to Marvell's brief description, it seems that it does support > fiber. > > Reading page 18 reg 30 returns 6. O.K, that is consistent. Looking at the Marvell SDK: phy/Include/madApiDefs.h:#defineMAD_SUB_88E1510 4

RE: Marvell Phy (1510) issue since v4.7 kernel

2017-01-11 Thread Kwok, WingMan
> Hi WingMan > > Do you know you really have a 1510? You can see it written on the > chip? > > Please can you read page 18, register 30 and let us know what value > you get. > > Andrew Removed Charles-Antonie from the list since the email address is no longer valid. Hi Andrew, I double c

Re: Marvell Phy (1510) issue since v4.7 kernel

2017-01-11 Thread Andrew Lunn
> > So i think the correct question should be, how can we tell the 88E1512 > > from the 88E1510 if they have the same ID in register 3. Hi WingMan Do you know you really have a 1510? You can see it written on the chip? Please can you read page 18, register 30 and let us know what value you get.

RE: Marvell Phy (1510) issue since v4.7 kernel

2017-01-11 Thread Kwok, WingMan
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Wednesday, January 11, 2017 6:00 PM > To: Kwok, WingMan > Cc: rmk+ker...@arm.linux.org.uk; charles-antoine.cou...@nexvision.fr; > Karicheri, Muralidharan; netdev@vger.kernel.org > Subject:

Re: Marvell Phy (1510) issue since v4.7 kernel

2017-01-11 Thread Andrew Lunn
> looping in Charles-Antoine (author of patch > with commit id 6cfb3bcc) > > Charles-Antoine, > > Do you have the ID of Marvell PHY 88E1512? I suspect that is the wrong question to ask. The Marvell driver is being loaded, so it must be using on of the IDs in the driver. There is no ID in the dr

RE: Marvell Phy (1510) issue since v4.7 kernel

2017-01-11 Thread Kwok, WingMan
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Wednesday, January 11, 2017 5:28 PM > To: Kwok, WingMan > Cc: Karicheri, Muralidharan; netdev@vger.kernel.org > Subject: Re: Marvell Phy (1510) issue since v4.7 kernel > > On Wed, Jan 11,

Re: Marvell Phy (1510) issue since v4.7 kernel

2017-01-11 Thread Andrew Lunn
nel.org > > Subject: Re: Marvell Phy (1510) issue since v4.7 kernel > > > > > From Marvell's brief description > > http://www.marvell.com/transceivers/alaska-gbe/, > > > it seems that 88E1510/1518 don't support fiber. Only 88E1512 does. > > In >

RE: Marvell Phy (1510) issue since v4.7 kernel

2017-01-11 Thread Kwok, WingMan
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Monday, January 09, 2017 8:54 PM > To: Kwok, WingMan > Cc: Karicheri, Muralidharan; netdev@vger.kernel.org > Subject: Re: Marvell Phy (1510) issue since v4.7 kernel > > > From Marvell

Re: Marvell Phy (1510) issue since v4.7 kernel

2017-01-09 Thread Andrew Lunn
> From Marvell's brief description > http://www.marvell.com/transceivers/alaska-gbe/, > it seems that 88E1510/1518 don't support fiber. Only 88E1512 does. In > that case, the fiber support patch is not applicable to 88E1510/1518. O.K. That makes it easier. Please add the relevant IDs to include/

RE: Marvell Phy (1510) issue since v4.7 kernel

2017-01-09 Thread Kwok, WingMan
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Monday, January 09, 2017 6:56 PM > To: Kwok, WingMan > Cc: Karicheri, Muralidharan; netdev@vger.kernel.org > Subject: Re: Marvell Phy (1510) issue since v4.7 kernel > > > But when kernel

Re: Marvell Phy (1510) issue since v4.7 kernel

2017-01-09 Thread Andrew Lunn
> But when kernel is reboot into u-boot, "mii read 0 0" shows > 0x1000, ie. bit 11 is 0, and still the phy auto-nego times out. O.K, not so simple then. I suggest you dump all the registers, in both the good and bad state, and see how they differ. Andrew

RE: Marvell Phy (1510) issue since v4.7 kernel

2017-01-09 Thread Kwok, WingMan
Hi Andrew, > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Monday, January 09, 2017 5:57 PM > To: Karicheri, Muralidharan > Cc: netdev@vger.kernel.org; Kwok, WingMan > Subject: Re: Marvell Phy (1510) issue since v4.7 kernel > > On Mo

Re: Marvell Phy (1510) issue since v4.7 kernel

2017-01-09 Thread Andrew Lunn
On Mon, Jan 09, 2017 at 05:38:39PM -0500, Murali Karicheri wrote: > Hello Charles-Antoine, Andrew, > > We have recently upgraded our kernel to v4.9 and started seeing an issue > on our Keystone EVMs (K2E/L) that uses Marvel Phy 1510. The issue is that > when we do a reboot command from the Linux c