RE: Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24

2008-02-01 Thread Waskiewicz Jr, Peter P
> I've changed the -EIO into NETDEV_TX_BUSY and so far I can't > trigger the bug anymore. It was quite easy to trigger within > minutes with rsync, but I can't trigger it anymore. Should I > send a patch, and if > so: to who? The tulip/xircom_cb driver seems to be orphaned. Perhaps Jeff Garzik

Re: Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24

2008-02-01 Thread Erik Mouw
On Tue, Jan 29, 2008 at 06:08:28PM -0500, jamal wrote: > On Tue, 2008-29-01 at 22:45 +0100, Erik Mouw wrote: > > > > The driver seems buggy. Make it return NETDEV_TX_BUSY instead of -EIO > > > in xircom_start_xmit() and the messages will go away. > > > > Like this? > > > > Indeed. I've change

RE: Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24

2008-01-29 Thread Waskiewicz Jr, Peter P
> Peter, I suspect that driver is just buggy in some other way > as opposed to being re-entered; couldnt tell by inspection. > It is possible it may be too eager to open up before it > really has space. > It will be easy to check your theory by having the driver > just check if it is netif_stop

Re: Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24

2008-01-29 Thread jamal
On Tue, 2008-29-01 at 22:45 +0100, Erik Mouw wrote: > > The driver seems buggy. Make it return NETDEV_TX_BUSY instead of -EIO > > in xircom_start_xmit() and the messages will go away. > > Like this? > Indeed. Peter, I suspect that driver is just buggy in some other way as opposed to being re-

RE: Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24

2008-01-29 Thread Waskiewicz Jr, Peter P
> > Are you using any specific qdisc, or just the default pfifo_fast? > > Have you done any specific tuning on your qdisc as well? > The default > > qlen seems to have been changed. > > The driver seems buggy. Make it return NETDEV_TX_BUSY instead > of -EIO in xircom_start_xmit() and the me

Re: Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24

2008-01-29 Thread Erik Mouw
On Tue, Jan 29, 2008 at 03:57:23PM -0500, jamal wrote: > On Tue, 2008-29-01 at 11:57 -0800, Waskiewicz Jr, Peter P wrote: > > > I've just started to use 2.6.24 on my home firewall (before > > > it was running 2.6.24-rc2 for about 65 days) and I noticed a > > > couple of error messages I've never

RE: Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24

2008-01-29 Thread jamal
On Tue, 2008-29-01 at 11:57 -0800, Waskiewicz Jr, Peter P wrote: > > I've just started to use 2.6.24 on my home firewall (before > > it was running 2.6.24-rc2 for about 65 days) and I noticed a > > couple of error messages I've never seen before: > > > > Jan 29 07:50:54 gateway kernel: BUG eth1

RE: Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24

2008-01-29 Thread Waskiewicz Jr, Peter P
> I've just started to use 2.6.24 on my home firewall (before > it was running 2.6.24-rc2 for about 65 days) and I noticed a > couple of error messages I've never seen before: > > Jan 29 07:50:54 gateway kernel: BUG eth1 code -5 qlen 0 Jan > 29 08:28:30 gateway kernel: BUG eth1 code -5 qlen 0 J