Re: Broken netlink ABI

2017-11-16 Thread David Ahern
; Jiri >> Pirko >> Cc: David Miller (da...@davemloft.net) >> Subject: Re: Broken netlink ABI >> >> On 11/14/17 1:15 PM, David Ahern wrote: >>> On 11/14/17 12:19 PM, Jon Maloy wrote: >>>> When I give the command: >>>> ~$ tipc node se

RE: Broken netlink ABI

2017-11-14 Thread Jon Maloy
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of David Ahern > Sent: Tuesday, November 14, 2017 15:18 > To: Jon Maloy ; netdev@vger.kernel.org; Jiri > Pirko > Cc: David Miller (da...@davemloft.net)

Re: Broken netlink ABI

2017-11-14 Thread David Ahern
On 11/14/17 1:15 PM, David Ahern wrote: > On 11/14/17 12:19 PM, Jon Maloy wrote: >> When I give the command: >> ~$ tipc node set addr 1.1.2 >> >> I get the following response: >> >> error: Numerical result out of range >> Unable to get TIPC nl family id (module loaded?) >> error, message initialisa

Re: Broken netlink ABI

2017-11-14 Thread David Ahern
On 11/14/17 12:19 PM, Jon Maloy wrote: > When I give the command: > ~$ tipc node set addr 1.1.2 > > I get the following response: > > error: Numerical result out of range > Unable to get TIPC nl family id (module loaded?) > error, message initialisation failed tipc is sending a u32 for the famil

Re: Broken netlink ABI

2017-11-14 Thread David Ahern
On 11/14/17 12:19 PM, Jon Maloy wrote: > commit 28033ae4e0f ("net: netlink: Update attr validation to require exact > length for some types") breaks the netlink ABI. It's not breaking the ABI; it's enforcing expected attributes based on policy. > > When I give the command: > ~$ tipc node set ad