RE: [v2 8/9] dpaa_eth: add debugfs entries

2015-08-11 Thread Madalin-Cristian Bucur
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > > From: Madalin Bucur > Date: Wed, 5 Aug 2015 18:41:28 +0300 > > > Export per CPU counters through debugfs. > > > > Signed-off-by: Madalin Bucur > > This is absolutely inappropriate. > > You can export these just

Re: [v2 8/9] dpaa_eth: add debugfs entries

2015-08-07 Thread David Miller
From: Madalin Bucur Date: Wed, 5 Aug 2015 18:41:28 +0300 > Export per CPU counters through debugfs. > > Signed-off-by: Madalin Bucur This is absolutely inappropriate. You can export these just fine via ethtool statistics. There is zero reason to add ugly debugfs crap for something like this.